-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI for MW 1.41 #894
Add CI for MW 1.41 #894
Conversation
@gesinn-it-gea / @gesinn-it-ilm I'm not sure why phpunit is getting killed with this. |
Seems it might be the integration tests? |
Adding @group Database seemed to allow it to proceed. |
Dunno why we're getting:
now? |
@gesinn-it-ilm any idea on a fix for it can't find the SRF\Tests\ResultPrinterReflector class? I can't seem to figure it out as we use addPsr4 in bootstrap and
Really is strange. |
Oh... using:
in extension.json fixed that. |
@gesinn-it-ilm Maybe we need to move https://github.com/SemanticMediaWiki/SemanticResultFormats/blob/master/Resources.php to extension.json? I dunno? Or change the check to check for if it's an array/string? |
looks like that function was changed in wikimedia/mediawiki@69ad795#diff-2bb9aed197663542c3ac9042287257d14a066acaf74d509ebee315022ca35022R338 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #894 +/- ##
============================================
+ Coverage 45.50% 45.51% +0.01%
Complexity 2319 2319
============================================
Files 80 80
Lines 9041 9043 +2
============================================
+ Hits 4114 4116 +2
Misses 4927 4927 ☔ View full report in Codecov by Sentry. |
Works now! |
@gesinn-it-ilm needs merging please :) |
No description provided.