Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for MW 1.41 #894

Merged
merged 16 commits into from
Dec 29, 2024
Merged

Add CI for MW 1.41 #894

merged 16 commits into from
Dec 29, 2024

Conversation

paladox
Copy link
Contributor

@paladox paladox commented Dec 27, 2024

No description provided.

@paladox paladox mentioned this pull request Dec 27, 2024
@paladox
Copy link
Contributor Author

paladox commented Dec 27, 2024

@gesinn-it-gea / @gesinn-it-ilm I'm not sure why phpunit is getting killed with this.

@paladox
Copy link
Contributor Author

paladox commented Dec 27, 2024

Seems it might be the integration tests?

@paladox
Copy link
Contributor Author

paladox commented Dec 27, 2024

Adding @group Database seemed to allow it to proceed.

@paladox
Copy link
Contributor Author

paladox commented Dec 27, 2024

Dunno why we're getting:

Error: Class "SRF\Tests\ResultPrinterReflector" not found

now?

@paladox
Copy link
Contributor Author

paladox commented Dec 27, 2024

@gesinn-it-ilm any idea on a fix for it can't find the SRF\Tests\ResultPrinterReflector class? I can't seem to figure it out as we use addPsr4 in bootstrap and $autoloader->addPsr4( 'SRF\\Tests\\', __DIR__ . '/phpunit' ); should basically pick it up. But we also have:

$autoloader->addClassMap( [
	'SRF\Tests\ResultPrinterReflector'             => __DIR__ . '/phpunit/ResultPrinterReflector.php',
] );

Really is strange.

@paladox
Copy link
Contributor Author

paladox commented Dec 27, 2024

Oh... using:

	"TestAutoloadNamespaces": {
		"SRF\\Tests\\": "tests/phpunit/"
	},

in extension.json fixed that.

@paladox
Copy link
Contributor Author

paladox commented Dec 27, 2024

@gesinn-it-ilm Maybe we need to move https://github.com/SemanticMediaWiki/SemanticResultFormats/blob/master/Resources.php to extension.json? I dunno? Or change the check to check for if it's an array/string?

@paladox
Copy link
Contributor Author

paladox commented Dec 27, 2024

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.51%. Comparing base (503e3f4) to head (7cdefad).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #894      +/-   ##
============================================
+ Coverage     45.50%   45.51%   +0.01%     
  Complexity     2319     2319              
============================================
  Files            80       80              
  Lines          9041     9043       +2     
============================================
+ Hits           4114     4116       +2     
  Misses         4927     4927              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paladox
Copy link
Contributor Author

paladox commented Dec 27, 2024

Works now!

@paladox
Copy link
Contributor Author

paladox commented Dec 28, 2024

@gesinn-it-ilm needs merging please :)

@gesinn-it-ilm gesinn-it-ilm merged commit ace37f7 into master Dec 29, 2024
5 checks passed
@gesinn-it-ilm gesinn-it-ilm deleted the paladox-patch-3 branch December 29, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants