Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require MW 1.39+ and at least SMW 4.2+ #900

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

paladox
Copy link
Contributor

@paladox paladox commented Jan 8, 2025

No description provided.

@JeroenDeDauw
Copy link
Member

Is this necessary? A bunch of improvements and fixes have been made, so it'd be nice to have another release for those on MW 35 with these

@alistair3149
Copy link
Contributor

We actually have to use SMW 5.0 since ef1c22f because of the ResourceLoader module changes.

We can add a version check for SMW for that change specifically to keep backward compatibility.

Other than that the DataTables changes might work in 1.35 since we backported all the Codex design tokens, but it would have to be tested

@JeroenDeDauw
Copy link
Member

If we have to jump through these extra hoops, then that is a good reason to raise the minimum requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants