forked from pytorch-labs/gpt-fast
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Art/llama3 support #1
Closed
nivibilla
wants to merge
15
commits into
SesameAILabs:art/llama3-support
from
nivibilla:art/llama3-support
Closed
Art/llama3 support #1
nivibilla
wants to merge
15
commits into
SesameAILabs:art/llama3-support
from
nivibilla:art/llama3-support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends this PR to support both llama 3 8b and 70b. |
It is great to see that 70B model works as well! Thanks for that! A couple of notes:
Here is what I think should be done:
What do you think? |
* WIP: llama3 support, tiktoken tokenizer * Finalizing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I was having a look at generalising this to llama 3 70b as well. I found that if we pre convert the safetensors version to a PyTorch pickle version. The model converts fine given the correct config.
And with your tokeniser changes generation should be good too. Pls have a look.
Ive converted and uploaded llama-3-8b-instruct and llama-3-70b-instruct to the native
pytorch_model_n_of_n.bin
for testing