Added SushiBarWrapAdapter #4
Conversation
| contract SushiBarWrapAdapter { | ||
|
|
||
| /* ============ State Variables ============ */ | ||
|
|
| * | ||
| * @param _underlyingToken Address of the component to be unwrapped to | ||
| * @param _wrappedToken Address of the wrapped component | ||
| * @param _wrappedTokenUnits Total quantity of wrapped units to wrap |
There was a problem hiding this comment.
Total quantity of wrapped units to unwrap - can maybe make a note that this is only xSUSHI
| * | ||
| * @param _underlyingToken Address of the component to be wrapped | ||
| * @param _wrappedToken Address of the wrapped component | ||
| * @param _underlyingUnits Total quantity of underlying units to wrap |
There was a problem hiding this comment.
Can maybe make note that this can only be SUSHI, same for wrappedToken and xSUSHI
| view | ||
| returns (address, uint256, bytes memory) | ||
| { | ||
| require(_underlyingToken == sushiToken, "Must be a valid token pair"); |
There was a problem hiding this comment.
Can we get different error messages for these so it's apparent which one is wrong
| view | ||
| returns (address, uint256, bytes memory) | ||
| { | ||
| require(_underlyingToken == sushiToken, "Must be a valid token pair"); |
There was a problem hiding this comment.
Different error messages would be better. Underlying token must be SUSHI or something to that effect
|
Hi @nateawelch! We are combining public and private repos here this week, moving all development to open source, and this PR has been ported to a new location: set-protocol-v2 56. To continue you'll need to fork the new repo, checkout the Apologies for the inconvenience and thanks so much for all the work you've done here. |
No description provided.