New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PriceOracle return constant price when base asset and quote asset are same #234

Open

gzliudan wants to merge 1 commit into SetProtocol:master from gzliudan:PriceOracle

Contributor

gzliudan commented Mar 26, 2022

In PriceOracle, when base asset equals quote asset, we can return 10**18 directly, no need to run other rules.

    function getPrice(address _assetOne, address _assetTwo) external view returns (uint256) {
        require(
            controller.isSystemContract(msg.sender),
            "PriceOracle.getPrice: Caller must be system contract."
        );

        if (_assetOne == _assetTwo) {
            return 10**18;
        }


          refactor(PriceOracle): return constant price when base asset and quot…

…e asset are same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet