Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to set PWM pin from config page #28

Merged
merged 7 commits into from
Jan 1, 2024
Merged

Ability to set PWM pin from config page #28

merged 7 commits into from
Jan 1, 2024

Conversation

ShadowLight8
Copy link
Owner

@ShadowLight8 ShadowLight8 commented Dec 28, 2023 •
edited
Loading

Prereq on FalconChristmas/fpp#1738 so the setting name is ultimately passed to the api - Has been merged, but only to master/fpp - Will likely be included in, I'm guessing, 7.5 or 8.0. The means the pwm pin setting will not work without this. Manually update /boot/config.txt for now.

  • Adds ability to set Hardware PWM Pin to use
  • Adds ability to PWM / Amp Power to be changed dynamically without an FPP restart

Other changes:

  • Addressed warnings about missing ' ' for object names
  • Found how to convert javascript array to object so JSON.stringify will work. Likely a FPP change needed for this
  • Removed old info about hardware pwm setup from config page
  • Split out engine into multiple file to easier maintenance in the future
  • Simplified api.php
  • Updated plugin description

@ShadowLight8 ShadowLight8 added enhancement New feature or request in progress Actively being worked on, more or less hardware Relates to physical hardware labels Dec 28, 2023
@ShadowLight8 ShadowLight8 self-assigned this Dec 28, 2023
@ShadowLight8 ShadowLight8 mentioned this pull request Dec 29, 2023
Open
@ShadowLight8
Found a way to pass all pluginSettings to the api call. Cleaned up a …
da6f6fe 
…few php warnings. Simplified api setup. Simplitied FastUpdate. Handle pluginSettings being passed to the api function. Updated to handle PWM pin change.
@ShadowLight8 ShadowLight8 added the FPP change A change or fix was needed in FPP label Dec 30, 2023
@ShadowLight8
Breakup engine into multiple files
72be71f 
Initial attempt as splitting engine into multiple files. Better for long term work.
@ShadowLight8
Config page side to make pwm power dynamic
847868d
@ShadowLight8
Minor tweaks to get multiple files working. MPC was already a dynamic…
bbe1fc0 
… setting, updated settings to show that. Clear RDS values when an update comes in.
@ShadowLight8
Added PWM change when update is called. Simple version for now and wi…
f145ce6 
…ll refactor with PWM improvements
@ShadowLight8 ShadowLight8 marked this pull request as ready for review January 1, 2024 02:18
@ShadowLight8 ShadowLight8 removed the in progress Actively being worked on, more or less label Jan 1, 2024
@ShadowLight8 ShadowLight8 merged commit a9078a3 into main Jan 1, 2024
2 checks passed
@ShadowLight8 ShadowLight8 deleted the pwm_pin branch January 1, 2024 03:14
@ShadowLight8 ShadowLight8 linked an issue Jan 14, 2024 that may be closed by this pull request
HifiBerry or alternative DAC for Dynamic_RDS #23
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ShadowLight8 ShadowLight8

Labels
enhancement New feature or request FPP change A change or fix was needed in FPP hardware Relates to physical hardware
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HifiBerry or alternative DAC for Dynamic_RDS
1 participant
@ShadowLight8