Add custom tag modal #1171
Add custom tag modal #1171
Conversation
revam
force-pushed
the
add-custom-tag-modal
branch
from
b6635ea to
c861c19
Compare
revam
force-pushed
the
add-custom-tag-modal
branch
from
c861c19 to
511bf11
Compare
There was a problem hiding this comment.
Other than the comments. The flow is confusing.
Separate the add/edit functionality into a separate modal and keep this one for just selecting the tag. Maybe we should put the add/edit away in the settings or something. But right now it's just confusing. And it also needs to allow removing or adding multiple tags at once. It does do that.. I was expecting I just select things and click on "save"
Tagging @ElementalCrisis for thoughts
EDIT: Just realized this is EC's design..
Tags in general need a better way to view/manage, being tied strictly to shows or applied in a filter leaves a lot to be desired. An idea I have is more global tag management where you can search/view tags, see how many series have them, easily manage custom tags, hide/ignore tags. Something we can look into for V3 if there is demand and want for it. |
Co-authored-by: Harshith Mohan <[email protected]>
I made sure the functionality of it is working as intended according to how I would assume it should work before I started this PR. As for all other aspects, feel free to roast it.
The final UI doesn't quite match the mock-ups, since I discovered while building/testing that a) the mock-up is old and the modal/dialog style is outdated compared to the current code base, and b) the lack of any indicator showing which tags are currently added/in-use, which I addressed, and c) the lack of any toggle for adding/removing tags from use on a series, which I also addressed.