TEST: relax method invocation checking for KernelRequireTest #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With ruby3.3.0dev, "require" method may invoke :to_str or :to_path more than once in ruby internal. To rescue this, relax method invocation checking for KernelRequireTest. Closes Shopify#459 .
|
The Ruby 2.6 failure is weird 🤔 |
|
I have signed the CLA! |
|
I'm able to reproduce it locally, using Ruby 2.6.9 but it requires the same test seed. So there is likely something leaking between tests. I wonder if perhaps it's the same reason you were having issues an me not? |
|
Nevermind, this leaky failure is pre-existing. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ruby3.3.0dev, "require" method may invoke :to_str or :to_path more than once in ruby internal. To rescue this, relax method invocation checking for KernelRequireTest.
Closes #459 .