Query app version directly by tag #5335
Draft
+254
−52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Completes https://github.com/Shopify/develop-app-inner-loop/issues/1862
Depends on https://github.com/Shopify/shopify/pull/575881
We are fetching all the versions from app management, and then iterating through them to find the one we want, and then re-fetching that one with full details. But we should just fetch the one we want immediately.
WHAT is this pull request doing?
Uses a new
versionByTag
field to query for just the version we want (also saves us a request).How to test your changes?
p shopify app versions list
and choose a different version than is currently deployed. (Best if the app has some extensions.)p shopify app release --version YOUR_VERSION_TAG
Measuring impact
How do we know this change was effective? Please choose one:
Checklist