Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query app version directly by tag #5335

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Query app version directly by tag #5335

wants to merge 1 commit into from

Conversation

amcaplan
Copy link
Contributor

@amcaplan amcaplan commented Feb 2, 2025

WHY are these changes introduced?

Completes https://github.com/Shopify/develop-app-inner-loop/issues/1862

Depends on https://github.com/Shopify/shopify/pull/575881

We are fetching all the versions from app management, and then iterating through them to find the one we want, and then re-fetching that one with full details. But we should just fetch the one we want immediately.

WHAT is this pull request doing?

Uses a new versionByTag field to query for just the version we want (also saves us a request).

How to test your changes?

  • List versions of an app you've deployed with p shopify app versions list and choose a different version than is currently deployed. (Best if the app has some extensions.)
  • p shopify app release --version YOUR_VERSION_TAG
    • Ensure the version is found correctly
    • Ensure the diff looks correct

Measuring impact

How do we know this change was effective? Please choose one:

  • Existing analytics will cater for this addition

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@amcaplan amcaplan requested a review from a team as a code owner February 2, 2025 09:46
@amcaplan amcaplan marked this pull request as draft February 2, 2025 09:47
Copy link
Contributor

github-actions bot commented Feb 2, 2025

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

github-actions bot commented Feb 2, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.51% (+0.06% 🔼)
9014/11938
🟡 Branches
70.68% (+0.04% 🔼)
4396/6220
🟡 Functions
75.29% (+0.02% 🔼)
2364/3140
🟡 Lines
76.03% (+0.06% 🔼)
8516/11201
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / app-version-by-tag.ts
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
95.18% (-1.2% 🔻)
86.49% (-2.7% 🔻)
95.45% 100%

Test suite run success

2035 tests passing in 909 suites.

Report generated by 🧪jest coverage report action from 3a63cf2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant