Skip to content

Commit

Permalink
Remove silenced warning by requiring necessary file (#758)
Browse files Browse the repository at this point in the history
Selenium::WebDriver::Remote::COMMANDS does not exist but instead it's
Selenium::WebDriver::Remote::Bridge::COMMANDS, defined in
selenium/webdriver/remote/commands

https://github.com/SeleniumHQ/selenium/blob/selenium-4.7.1-ruby/rb/lib/selenium/webdriver/remote.rb#L30
  • Loading branch information
etiennebarrie authored Jan 25, 2023
1 parent 4e57cee commit 02ca393
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
1 change: 1 addition & 0 deletions test/application_system_test_case.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

require "test_helper"
require "webdrivers/chromedriver"
require "selenium/webdriver/remote/commands"
require "action_dispatch/system_testing/server"

ActionDispatch::SystemTesting::Server.silence_puma = true
Expand Down
5 changes: 0 additions & 5 deletions test/test_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,6 @@
module Warning
class << self
def warn(message)
# gems/selenium-webdriver-4.7.1/lib/selenium/webdriver/remote/bridge.rb:633:
# warning: Expected selenium/webdriver/remote/commands
# to define Selenium::WebDriver::Remote::COMMANDS but it didn't
return if message.match?(/Selenium::WebDriver::Remote::COMMANDS/)

raise message.to_s
end
end
Expand Down

0 comments on commit 02ca393

Please sign in to comment.