Fix rubocop

Rakefile

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 begin
   require "bundler/setup"
 rescue LoadError

app/helpers/maintenance_tasks/application_helper.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module MaintenanceTasks
   # Module for common view helpers.
   #

app/jobs/concerns/maintenance_tasks/task_job_concern.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module MaintenanceTasks
   # Concern that holds the behaviour of the job that runs the tasks. It is
   # included in {TaskJob} and if MaintenanceTasks.job is overridden, it must be

app/models/maintenance_tasks/application_record.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module MaintenanceTasks
   # Base class for all records used by this engine.
   #

app/models/maintenance_tasks/run.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module MaintenanceTasks
   # Model that persists information related to a task being run from the UI.
   #

app/models/maintenance_tasks/runs_page.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module MaintenanceTasks
   # This class is responsible for handling cursor-based pagination for Run
   # records.

app/models/maintenance_tasks/task.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module MaintenanceTasks
   # Base class that is inherited by the host application's task classes.
   class Task

app/models/maintenance_tasks/task_data.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module MaintenanceTasks
   # Class that represents the data related to a Task. Such information can be
   # sourced from a Task or from existing Run records for a Task that was since

app/validators/maintenance_tasks/run_status_validator.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module MaintenanceTasks
   # Custom validator class responsible for ensuring that transitions between
   # Run statuses are valid.

bin/rails

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
+
 # This command will automatically be run when you run "rails" with Rails gems
 # installed from the root of your application.
 

config/routes.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 MaintenanceTasks::Engine.routes.draw do
   resources :tasks, only: [:index, :show], format: false do
     member do

db/migrate/20201211151756_create_maintenance_tasks_runs.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 class CreateMaintenanceTasksRuns < ActiveRecord::Migration[6.0]
   def change
     create_table(:maintenance_tasks_runs) do |t|

db/migrate/20210225152418_remove_index_on_task_name.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 class RemoveIndexOnTaskName < ActiveRecord::Migration[6.0]
   def up
     change_table(:maintenance_tasks_runs) do |t|

db/migrate/20210517131953_add_arguments_to_maintenance_tasks_runs.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 class AddArgumentsToMaintenanceTasksRuns < ActiveRecord::Migration[6.0]
   def change
     add_column(:maintenance_tasks_runs, :arguments, :text)

lib/generators/maintenance_tasks/install_generator.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module MaintenanceTasks
   # Generator used to set up the engine in the host application. It handles
   # mounting the engine and installing migrations.

lib/maintenance_tasks.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "action_controller"
 require "action_view"
 require "active_job"
@@ -73,7 +74,7 @@ def self.error_handler=(error_handler)
     unless error_handler.arity == 3
       ActiveSupport::Deprecation.warn(
         "MaintenanceTasks.error_handler should be a lambda that takes three "\
-         "arguments: error, task_context, and errored_element."
+          "arguments: error, task_context, and errored_element."
       )
       @error_handler = ->(error, _task_context, _errored_element) do
         error_handler.call(error)

lib/maintenance_tasks/cli.rb

@@ -25,12 +25,13 @@ def exit_on_failure?
     LONGDESC
 
     # Specify the CSV file to process for CSV Tasks
-    option :csv, desc: "Supply a CSV file to be processed by a CSV Task, "\
-      '--csv "path/to/csv/file.csv"'
-
+    desc = "Supply a CSV file to be processed by a CSV Task, "\
+      "--csv path/to/csv/file.csv"
+    option :csv, desc: desc
     # Specify arguments to supply to a Task supporting parameters
-    option :arguments, type: :hash, desc: "Supply arguments for a Task that "\
-      "accepts parameters as a set of <key>:<value> pairs."
+    desc = "Supply arguments for a Task that accepts parameters as a set of "\
+      "<key>:<value> pairs."
+    option :arguments, type: :hash, desc: desc
 
     # Command to run a Task.
     #

lib/maintenance_tasks/engine.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "active_record/railtie"
 
 module MaintenanceTasks

test/documentation_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "active_support"
 require "active_support/test_case"
 require "yard"

test/dummy/app/channels/application_cable/channel.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module ApplicationCable
   class Channel < ActionCable::Channel::Base
   end

test/dummy/app/channels/application_cable/connection.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module ApplicationCable
   class Connection < ActionCable::Connection::Base
   end

test/dummy/app/controllers/application_controller.rb

@@ -1,3 +1,4 @@
 # frozen_string_literal: true
+
 class ApplicationController < ActionController::Base
 end

test/dummy/app/controllers/posts_controller.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 class PostsController < ApplicationController
   before_action :set_post, only: [:show, :edit, :update, :destroy]
 

test/dummy/app/helpers/application_helper.rb

@@ -1,3 +1,4 @@
 # frozen_string_literal: true
+
 module ApplicationHelper
 end

test/dummy/app/mailers/application_mailer.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 class ApplicationMailer < ActionMailer::Base
   default from: "[email protected]"
   layout "mailer"

test/dummy/app/models/application_record.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 class ApplicationRecord < ActiveRecord::Base
   self.abstract_class = true
 end

test/dummy/app/models/post.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 class Post < ApplicationRecord
   validates :title, presence: true
   validates :content, presence: true

test/dummy/app/tasks/maintenance/callback_test_task.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Maintenance
   class CallbackTestTask < MaintenanceTasks::Task
     after_start :after_start_callback

test/dummy/app/tasks/maintenance/cancelled_enqueue_task.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Maintenance
   # Any job enqueued for this task gets cancelled, see CustomTaskJob.
   class CancelledEnqueueTask < MaintenanceTasks::Task

test/dummy/app/tasks/maintenance/enqueue_error_task.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Maintenance
   # Any job enqueued for this task errors, see CustomTaskJob.
   class EnqueueErrorTask < MaintenanceTasks::Task

test/dummy/app/tasks/maintenance/error_task.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Maintenance
   class ErrorTask < MaintenanceTasks::Task
     def collection

test/dummy/app/tasks/maintenance/import_posts_task.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Maintenance
   class ImportPostsTask < MaintenanceTasks::Task
     csv_collection

test/dummy/app/tasks/maintenance/params_task.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Maintenance
   class ParamsTask < MaintenanceTasks::Task
     attribute :post_ids, :string

test/dummy/app/tasks/maintenance/test_task.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Maintenance
   class TestTask < MaintenanceTasks::Task
     def collection

test/dummy/app/tasks/maintenance/update_posts_in_batches_task.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Maintenance
   class UpdatePostsInBatchesTask < MaintenanceTasks::Task
     def collection

test/dummy/app/tasks/maintenance/update_posts_task.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Maintenance
   class UpdatePostsTask < MaintenanceTasks::Task
     class << self

test/dummy/app/tasks/maintenance/update_posts_throttled_task.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Maintenance
   class UpdatePostsThrottledTask < MaintenanceTasks::Task
     class << self

test/dummy/bin/rails

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
+
 APP_PATH = File.expand_path("../config/application", __dir__)
 require_relative "../config/boot"
 require "rails/commands"

test/dummy/bin/rake

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
+
 require_relative "../config/boot"
 require "rake"
 Rake.application.run

test/dummy/bin/setup

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
+
 require "fileutils"
 
 # path to your application root.

test/dummy/config.ru

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # This file is used by Rack-based servers to start the application.
 
 require_relative "config/environment"

test/dummy/config/application.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative "boot"
 
 verbose = $VERBOSE

test/dummy/config/boot.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Set up gems listed in the Gemfile.
 ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../../Gemfile", __dir__)
 

test/dummy/config/environment.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Load the Rails application.
 require_relative "application"
 

test/dummy/config/environments/development.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "active_support/core_ext/integer/time"
 
 Rails.application.configure do

test/dummy/config/environments/production.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "active_support/core_ext/integer/time"
 
 Rails.application.configure do

test/dummy/config/environments/test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "active_support/core_ext/integer/time"
 
 # The test environment is used exclusively to run your application's

test/dummy/config/initializers/assets.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Version of your assets, change this if you want to expire all your assets.

test/dummy/config/initializers/backtrace_silencers.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # You can add backtrace silencers for libraries that you're using but don't

test/dummy/config/initializers/content_security_policy.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Define an application-wide content security policy

test/dummy/config/initializers/cookies_serializer.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Specify a serializer for the signed and encrypted cookie jars.

test/dummy/config/initializers/filter_parameter_logging.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Configure sensitive parameters which will be filtered from the log file.

test/dummy/config/initializers/wrap_parameters.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # This file contains settings for ActionController::ParamsWrapper which

test/dummy/config/puma.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Puma can serve each request in a thread from an internal thread pool.
 # The `threads` method setting takes two numbers: a minimum and maximum.
 # Any libraries that use thread pools should be configured to match

test/dummy/config/routes.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Rails.application.routes.draw do
   mount MaintenanceTasks::Engine => "/maintenance_tasks"
   resources :posts

test/dummy/config/spring.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Spring.watch(
   ".ruby-version",
   ".rbenv-vars",

test/dummy/db/migrate/20200923173403_create_posts.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 class CreatePosts < ActiveRecord::Migration[6.0]
   def change
     create_table(:posts) do |t|

test/dummy/db/migrate/20210112141723_create_active_storage_tables.active_storage.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # This migration comes from active_storage (originally 20170806125915)
 class CreateActiveStorageTables < ActiveRecord::Migration[5.2]
   def change

test/dummy/db/seeds.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 10.times do |i|
   Post.create!(title: "Post ##{i}", content: "Content ##{i}")
 end

test/helpers/maintenance_tasks/application_helper_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "test_helper"
 
 module MaintenanceTasks

test/jobs/maintenance_tasks/task_job_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "test_helper"
 require "job-iteration"
 
@@ -132,7 +133,7 @@ class TaskJobTest < ActiveJob::TestCase
       run.expects(:persist_error).with do |exception|
         assert_kind_of ArgumentError, exception
         assert_equal "Something went wrong", exception.message
-        expected = "app/tasks/maintenance/error_task.rb:9:in `process'"
+        expected = "app/tasks/maintenance/error_task.rb:10:in `process'"
         assert_match expected, exception.backtrace.first
       end