handle title link click

Shopify · Apr 25, 2024 · 2720e9f · 2720e9f
1 parent 5d4d60d
commit 2720e9f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/polaris-react/src/components/AppCardMetadata/components/AppCardAppTitle/AppCardAppTitle.tsx b/polaris-react/src/components/AppCardMetadata/components/AppCardAppTitle/AppCardAppTitle.tsx
@@ -26,10 +26,20 @@ export function AppCardAppTitle({
   truncate = false,
   appTitle,
 }: AppCardAppTitleProps) {
+  const handleOnClick = (event: React.MouseEvent) => {
+    event.preventDefault();
+    event.stopPropagation();
+    onTitleClick();
+  };
+
   const textVariant = VARIANT_TO_TEXT_VARIANT[variant ?? 'default'];
   return (
     <div className={styles.TitleContainer}>
-      <UnstyledLink className={styles.TitleLink} onClick={onTitleClick}>
+      <UnstyledLink
+        url="#"
+        className={styles.TitleLink}
+        onClick={handleOnClick}
+      >
         <Text truncate={truncate} variant={textVariant} as="h3">
           {appTitle}
         </Text>

diff --git a/polaris-react/src/components/AppIcon/AppIcon.tsx b/polaris-react/src/components/AppIcon/AppIcon.tsx
@@ -57,6 +57,7 @@ export function AppIcon({
 
   return (
     <UnstyledLink
+      href="#"
       role={source ? 'link' : 'region'}
       className={!disabled ? styles.IconLink : undefined}
       onClick={handleClick}