Skip to content

Commit

Permalink
[LegacyFilters] Fixed button spacing on ConnectedFilterControl (#11317
Browse files Browse the repository at this point in the history
)

<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Open it as a draft if it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #10216

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

Before


https://github.com/Shopify/polaris/assets/4642404/657acfd9-4b53-4860-999f-7527603eb357


After


https://github.com/Shopify/polaris/assets/4642404/cfd07deb-7dc0-4435-95e4-91b06390dc96


<!--
  Summary of the changes committed.

Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.

  Include a video if your changes include interactive content.

If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:

  <details>
    <summary>Summary of your gif(s)</summary>
    <img src="..." alt="Description of what the gif shows">
  </details>
-->

### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [ ] Tested a
[snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases)
- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide

---------

Co-authored-by: Alex Page <[email protected]>
  • Loading branch information
Yuraima Estevez and alex-page authored Dec 14, 2023
1 parent bc4272a commit e197ca5
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/little-gorillas-deny.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': minor
---

[LegacyFilters] Fixed button spacing on `ConnectedFilterControl`
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,8 @@
}

.MoreFiltersButtonContainer.onlyButtonVisible {
padding-left: 0;

.Item > div > button {
border-radius: var(--p-border-radius-200);
}
Expand All @@ -122,4 +124,9 @@

.AuxiliaryContainer {
flex-grow: 0;
margin-left: var(--p-space-200);

@media #{$p-breakpoints-md-up} {
margin-left: 0;
}
}

0 comments on commit e197ca5

Please sign in to comment.