Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LegacyFilters] Fixed button spacing on ConnectedFilterControl #11317

Merged
merged 8 commits into from
Dec 14, 2023
Merged

[LegacyFilters] Fixed button spacing on ConnectedFilterControl #11317

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
003a7bf
Removed padding left and added margin right
Dec 11, 2023
3dbf227
changeset
Dec 11, 2023
4746298
Remove unnecessary nesting
Dec 11, 2023
292e8a3
restored class selector
Dec 11, 2023
0fce2e2
Merge branch 'ye/legacy-filters-btn-spacing' of https://github.com/Sh…
Dec 11, 2023
8cadfc2
remove `:has and add media query for sm breakpoints
Dec 11, 2023
a5ad1ed
add `md` media queries for spacing
Dec 12, 2023
bfb4d33
remove md-down query
Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/little-gorillas-deny.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': minor
---

[LegacyFilters] Fixed button spacing on `ConnectedFilterControl`
8 changes: 7 additions & 1 deletion ...rc/components/LegacyFilters/components/ConnectedFilterControl/ConnectedFilterControl.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// stylelint-disable selector-max-specificity -- generated by polaris-migrator DO NOT COPY
// stylelint-disable selector-max-compound-selectors -- generated by polaris-migrator DO NOT COPY
// stylelint-disable selector-max-type -- generated by polaris-migrator DO NOT COPY
.ConnectedFilterControl {
{
// stylelint-disable -- polaris/conventions/polaris/custom-property-allowed-list
--pc-connceted-filter-control-item: 10;
--pc-connceted-filter-control-focused: 20;
Expand All @@ -24,6 +24,10 @@
border-bottom-right-radius: var(--p-border-radius-200);
}
}

&:has(.MoreFiltersButtonContainer.onlyButtonVisible) + * {
margin-left: var(--p-space-200);
}
}

.Item {
Expand Down Expand Up @@ -110,6 +114,8 @@
}

.MoreFiltersButtonContainer.onlyButtonVisible {
padding-left: 0;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgriffee I think this should address your feedback and make sure that these changes don't affect the spacing at larger breakpoints


.Item > div > button {
border-radius: var(--p-border-radius-200);
}
Expand Down