-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Banner
mobile styles
#11959
Update Banner
mobile styles
#11959
Conversation
Banner
mobile stylesBanner
mobile styles
action={{content: 'Primary'}} | ||
secondaryAction={{content: 'Secondary'}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this change so we can see some examples of buttons side by side instead of stacked on small screens
a044421
to
9af95d3
Compare
Banner
mobile stylesBanner
mobile styles
Co-authored-by: Aveline Thelen <[email protected]>
9af95d3
to
a87d4e1
Compare
@davebcn87 Good callout! Definitely agree about the alignment there. I hadn't originally based this PR off the typography updates but your right that it's an important factor in reviewing all the alignment. I've updated the PR do that now (see screenshots above in the PR description), but now the body text looks giant. Not sure if we will need to adjust the Banner font sizes to compensate? Might be worth it for me to book some time with @heyjoethomas to figure out how we want to handle that (or to just bring it up during our Banner meeting tomorrow). In the meantime I'll work on aligning the title better for the InlineIconBanners. |
@davebcn87 I've updated the title alignment on the InlineIconBanners in 1f08404 |
Closing in favor of build phase PR |
WHY are these changes introduced?
Closes https://github.com/Shopify/mobile/issues/33410
WHAT is this pull request doing?
sm
breakpointInlineIconBanner
s belowsm
breakpointsm
breakpointsm
breakpointsm
breakpoint)sm
breakpoint)