Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IndexFilters] Prototype "add as filter" search input UX #12573

Closed
wants to merge 6 commits into from
Closed

[IndexFilters] Prototype "add as filter" search input UX #12573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e933d8d
[IndexFilters] Prototype "add as filter" search input UX
chloerice Aug 15, 2024
4140941
[IndexFilters][SearchField] Make add as filter a button
chloerice Aug 26, 2024
1d73669
Fix commas not being escaped and being removed when moving to another…
chloerice Aug 26, 2024
a9d66b2
unsaved changes not being recognized on filter removal
chloerice Aug 26, 2024
6170aeb
remove unused import
chloerice Aug 27, 2024
4e24ec7
polish input border and button styles
chloerice Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion polaris-react/.storybook/RenderPerformanceProfiler/RenderPerformanceProfiler.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import React, {PropsWithChildren} from 'react';
import React from 'react';
import type {PropsWithChildren} from 'react';

interface Data {
id: string;
Expand Down
15 changes: 12 additions & 3 deletions polaris-react/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,18 @@
"unsavedChanges": "Unsaved changes - {label}"
},
"IndexFilters": {
"searchFilterTooltip": "Search and filter",
"searchFilterTooltipWithShortcut": "Search and filter (F)",
"searchFilterAccessibilityLabel": "Search and filter results",
"searchFilterTooltip": "Filter",
"searchFilterTooltipWithShortcut": "Filter (F)",
"searchFilterAccessibilityLabel": "Type a query to search the list, and keypress enter to add your query as a filter",
"editSearchFilter": "Edit search filter",
"SearchField": {
"defaultPlaceholder": "Search",
"action": {
"addAsFilter": "add as filter",
"addToFilter": "add to filter",
"accessibilityLabel": "Add search query as a list filter"
}
},
"sort": "Sort your results",
"addView": "Add a new view",
"newView": "Custom search",
Expand Down
Loading
Loading