Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack Days 34 Unified Color Picker #9843

Closed
wants to merge 8 commits into from

Conversation

acmertz
Copy link
Contributor

@acmertz acmertz commented Jul 26, 2023

WHY are these changes introduced?

The current <ColorPicker /> in Polaris only contains elements for visual point-and-click color selection, but since we often need to include a text field for the hex code when displaying a color picker we have ended up with a variety of implementations that all function similarly to each other.

Examples:Color pickers that re-implement the hex code text field

This PR builds upon the ideas introduced in #8294.

WHAT is this pull request doing?

Brings the hex code text field functionality into the <ColorPicker /> component itself and adds a boolean option for displaying it so existing implementations that use the color picker aren't adversely affected and can opt into the new functionality when they're ready.

To do: add an option to display a list of color swatches in the color picker so that this functionality doesn't have to be separately implemented by consumers of the <ColorPicker /> component.

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

@acmertz
Copy link
Contributor Author

acmertz commented Jul 26, 2023

/snapit

@acmertz acmertz changed the title Add WIP readme Hack Days 34 Unified Color Picker Jul 26, 2023
@acmertz
Copy link
Contributor Author

acmertz commented Jul 26, 2023

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @acmertz! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/[email protected]
yarn add @shopify/[email protected]

@natachalevesque natachalevesque force-pushed the hack-days-34-unified-color-picker branch from 451e101 to c5878f0 Compare July 26, 2023 20:26
@natachalevesque
Copy link

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @natachalevesque! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/[email protected]
yarn add @shopify/[email protected]

@ruairiphackett
Copy link
Contributor

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @ruairiphackett! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/[email protected]
yarn add @shopify/[email protected]

@runmad
Copy link

runmad commented Jul 27, 2023

/snapit

@acmertz
Copy link
Contributor Author

acmertz commented Jul 28, 2023

/snapit

@acmertz
Copy link
Contributor Author

acmertz commented Jul 28, 2023

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @acmertz! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/[email protected]
yarn add @shopify/[email protected]

@natachalevesque
Copy link

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @natachalevesque! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/[email protected]
yarn add @shopify/[email protected]

@natachalevesque
Copy link

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @natachalevesque! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/[email protected]
yarn add @shopify/[email protected]

@acmertz acmertz closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants