-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hack Days 34 Unified Color Picker #9843
Conversation
/snapit |
/snapit |
🫰✨ Thanks @acmertz! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected] yarn add @shopify/[email protected] |
451e101
to
c5878f0
Compare
/snapit |
🫰✨ Thanks @natachalevesque! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected] yarn add @shopify/[email protected] |
/snapit |
🫰✨ Thanks @ruairiphackett! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected] yarn add @shopify/[email protected] |
/snapit |
/snapit |
/snapit |
🫰✨ Thanks @acmertz! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected] yarn add @shopify/[email protected] |
/snapit |
🫰✨ Thanks @natachalevesque! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected] yarn add @shopify/[email protected] |
/snapit |
🫰✨ Thanks @natachalevesque! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected] yarn add @shopify/[email protected] |
WHY are these changes introduced?
The current
<ColorPicker />
in Polaris only contains elements for visual point-and-click color selection, but since we often need to include a text field for the hex code when displaying a color picker we have ended up with a variety of implementations that all function similarly to each other.Examples:
This PR builds upon the ideas introduced in #8294.
WHAT is this pull request doing?
Brings the hex code text field functionality into the
<ColorPicker />
component itself and adds a boolean option for displaying it so existing implementations that use the color picker aren't adversely affected and can opt into the new functionality when they're ready.To do: add an option to display a list of color swatches in the color picker so that this functionality doesn't have to be separately implemented by consumers of the
<ColorPicker />
component.How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx
:🎩 checklist
README.md
with documentation changes