Include unknown fields from decoding into output when re-encoding #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwstauner
force-pushed
the
unknown-fields
branch
3 times, most recently
from
cfcadc9 to
a49172c
Compare
When a message is decoded that has fields the current module doesn't utilize, just append them to the end of the message when re-encoding a message from this instance. The conformance suite tests for this.
rwstauner
force-pushed
the
unknown-fields
branch
from
a49172c to
26de9f8
Compare
tenderworks
approved these changes
Jan 8, 2025
rwstauner
added
the
#gsd:43107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a message is decoded that has fields the current module doesn't utilize, just append them to the end of the message when re-encoding a message from this instance.
The conformance suite tests for this.