Introduce a ProtoBoeuf::CodeGen::Field to alleviate feature envy #181
+273
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
davebenvenuti
added
the
#gsd:43107
rwstauner
approved these changes
Jan 31, 2025
davebenvenuti
commented
Jan 31, 2025
Comment on lines
+8
to
+9
| require "protoboeuf/codegen/type_helper" | ||
| require "protoboeuf/codegen/field" |
There was a problem hiding this comment.
Not 100% sure whether require inside the class is more appropriate than autoload. See this discussion:
There was a problem hiding this comment.
I'm also not convinced this is worth blocking this PR over, but I'd like to resolve this as a best practice in the near future.
davebenvenuti
force-pushed
the
davebenvenuti/decorated-field
branch
from
ea7bac9 to
ec488bc
Compare
davebenvenuti
commented
Jan 31, 2025
| @@ -74,7 +74,7 @@ rule ".rb" => ["%X.proto"] + codegen_rb_files do |t| | |||
| File.binwrite(t.name, ProtoBoeuf::CodeGen.new(unit).to_ruby(dest, options)) | |||
| end | |||
|
|
|||
| rule ".rb" => "%X" do |t| | |||
| rule %r{lib/protoboeuf/google/.+\.rb} => "%X" do |t| | |||
There was a problem hiding this comment.
lib/protoboeuf/codegen.rb was getting caught here with the addition of the lib/protoboeuf/codegen directory, which we don't want.
davebenvenuti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on Hash serialization support I found myself wanting to define a new compiler which our existing
ProtoBoeuf::CodeGen::MessageCompilercould delegate to. Those changes required several private helper methods which started to makeMessageCompilerfeel cluttered. There were also a number of helper methods like#repeated?(field)or#optional?(field)which feel more like functionality we wish we had right onField. This PR introduces aDecoratedFieldwhich provides this functionality and moves these helper methods out ofMessageCompiler. The end result is more OO, and also makes it easier to introduce Codegen functionality outside ofMessageCompiler. Alternatively, these helper methods could have just been made into class methods to make them globally accessible, but that felt like more of a hack.