Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement read_bct() from svFSI, add some VTK funcions needed to proc… #166

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Implement read_bct() from svFSI, add some VTK funcions needed to proc… #166

merged 1 commit into from
Dec 19, 2023

Conversation

ktbolt
Copy link
Collaborator

@ktbolt ktbolt commented Dec 15, 2023

These are the code changes to implement Dirichlet BCs for Time_dependence: General (see #161).

I believe @wgyang will add a new test for this type of simulation.

MatteoSalvador
MatteoSalvador requested changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@MatteoSalvador MatteoSalvador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ktbolt, I think this can be merged after @wgyang adds a test case

@wgyang
Copy link
Contributor

wgyang commented Dec 15, 2023

Thanks @ktbolt, I think this can be merged after @wgyang adds a test case

Yes, will do. The test case for cmm with variable wall properties will contain a rigid case as the initial step in which user-defined bct inflow can be tested.

@MatteoSalvador MatteoSalvador merged commit c4a1cc6 into SimVascular:main Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatteoSalvador MatteoSalvador MatteoSalvador approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktbolt @wgyang @MatteoSalvador