Improve ustruct/LV_Guccione_active convergence #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erence solution, and add README.md and animations.
1 task
mrp089
approved these changes
Feb 10, 2025
|
@aabrown100-git Do you understand why the nonlinear convergence improves when the stabilization coefficients are reduced ? Maybe this information should go in the README. |
aabrown100-git
deleted the
Improve-ustruct/LV_Guccione_active-convergence
branch
|
@ktbolt Unfortunately no, I don't understand why reducing the ustruct stabilization coefficients improves nonlinear convergence. @vvedula22 Do you happen to know? |
|
I think because you are adding non-linearity to the system. The supg term that control convection stability is a term: tau*delta W * U* Residual. Having a higher tau makes this non lienar term higher which can impact your convergence.
That is my opinion at least.
David
…________________________________
From: Aaron Brown ***@***.***>
Sent: Monday, February 10, 2025 10:04 AM
To: SimVascular/svMultiPhysics ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [SimVascular/svMultiPhysics] Improve ustruct/LV_Guccione_active convergence (PR #337)
@ktbolt<https://github.com/ktbolt> Unfortunately no, I don't understand why reducing the ustruct stabilization coefficients improves nonlinear convergence. @vvedula22<https://github.com/vvedula22> Do you happen to know?
—
Reply to this email directly, view it on GitHub<#337 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BGFJA75PLECESOLMUQJTW5L2PDS2DAVCNFSM6AAAAABWW7UVJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBYHAZTQMRTGY>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
Building on that, it may be that the tangent matrix does not include linearizations of the stabilization terms (an inconsistent tangent), which would explain why larger stabilizations coefficients worsen nonlinear convergence. |
divyaadil23
pushed a commit
to divyaadil23/svFSIplus
that referenced
this pull request
Feb 12, 2025
Reduce momentum and continuity stabilization coefficients, update reference solution, and add README.md and animations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current situation
Resolve #197
Release Notes
result_001.vtuaccordinglyTesting
No testing required. Note however that this modifies the reference solution in ustruct/LV_Guccione_active
Code of Conduct & Contributing Guidelines