Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check spatial dimension #339

Merged
merged 25 commits into from
Feb 10, 2025
Merged

Conversation

ktbolt
Copy link
Collaborator

@ktbolt ktbolt commented Feb 10, 2025

Check for consistency with the Number_of_spatial_dimensions parameter set in the solver XML file and the dimension of the elements used for the finite element mesh. #300

@ktbolt ktbolt requested review from msbazzi and dcodoni February 10, 2025 17:23
Copy link
Contributor

@dcodoni dcodoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ktbolt for doing this!

@ktbolt
Copy link
Collaborator Author

ktbolt commented Feb 10, 2025

I messed up 1d and shells in 3d, and setting element type for a mesh defined in a vtp file. I think I got it right this time.

@ktbolt ktbolt merged commit c3fac1e into SimVascular:main Feb 10, 2025
5 checks passed
divyaadil23 pushed a commit to divyaadil23/svFSIplus that referenced this pull request Feb 12, 2025
* Change file name.

* Add setting the mesh element type from vtk cell type and a check for spatial dimension consistent with mesh element type.

* Change to check using element dimension.

* Add check for fiber mesh.

* Add setting mesh element type for vtp files, reorganize checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants