-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check spatial dimension #339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…spatial dimension consistent with mesh element type.
dcodoni
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ktbolt for doing this!
I messed up 1d and shells in 3d, and setting element type for a mesh defined in a vtp file. I think I got it right this time. |
dcodoni
approved these changes
Feb 10, 2025
divyaadil23
pushed a commit
to divyaadil23/svFSIplus
that referenced
this pull request
Feb 12, 2025
* Change file name. * Add setting the mesh element type from vtk cell type and a check for spatial dimension consistent with mesh element type. * Change to check using element dimension. * Add check for fiber mesh. * Add setting mesh element type for vtp files, reorganize checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for consistency with the
Number_of_spatial_dimensions
parameter set in the solver XML file and the dimension of the elements used for the finite element mesh. #300