Fsi ustruct #341
Open
Fsi ustruct #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktbolt
reviewed
Feb 11, 2025
| if (cPhys == Equation_ustruct) | ||
| { | ||
| ustruct::ustruct_do_assem(com_mod, eNoN, ptr, lKd, lK, lR); | ||
| } |
There was a problem hiding this comment.
Are you assembling twice, calling ustruct::ustruct_do_assem() and then eq.linear_algebra->assemble() ?
ktbolt
reviewed
Feb 11, 2025
There was a problem hiding this comment.
This is not the mesh we are using in the test.
ktbolt
reviewed
Feb 11, 2025
There was a problem hiding this comment.
Why are we using brick elements ?
There was a problem hiding this comment.
We could also just add another input file to an existing mesh without copying the mesh. We may be already doing that for another test case.
Code/Source/solver/fsi.cpp
Outdated
| auto N0 = fs_1[0].N.col(g); | ||
| auto N1 = fs_1[1].N.col(g); | ||
| ustruct::ustruct_3d_m(com_mod, cep_mod, vmsStab, fs_1[0].eNoN, fs_1[1].eNoN, nFn, w, Jac, N0, N1, Nwx, al, yl, dl, bfl, fN, ya_l, lR, lK, lKd); | ||
| //throw std::runtime_error("[construct_fsi] USTRUCT3D_M not implemented"); |
There was a problem hiding this comment.
Can remove this comment
Code/Source/solver/fsi.cpp
Outdated
| auto N0 = fs_2[0].N.col(g); | ||
| auto N1 = fs_2[1].N.col(g); | ||
| ustruct::ustruct_3d_c(com_mod, cep_mod, vmsStab, fs_2[0].eNoN, fs_2[1].eNoN, w, Jac, N0, N1, Nwx, Nqx, al, yl, dl, bfl, lR, lK, lKd); | ||
| //throw std::runtime_error("[construct_fsi] USTRUCT3D_C not implemented"); |
There was a problem hiding this comment.
Can remove this comment
Updating the reference result_*.vtu file in the tests folder.
…dir_wl (SimVascular#342) Co-authored-by: Martin Pfaller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addin 'ustruct' to the FSI framework
Current situation
Currently the FSI framework allows to use only the 'struct' formulation for solving the solid portion. The 'ustruct' formulation would benefit the FSI framework in terms of consistency (fluid and solid will solve for the same degrees of freedom and have similar formulations) and performance, since block iterative methods could be used to solve the fully assembled monolithic system.
Release Notes
I added the 'ustruct' formulation to the FSI framework and new test cases are added.
Testing
New tests added in the fsi tests folder:
Code of Conduct & Contributing Guidelines