Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pow #654

Merged
merged 32 commits into from
Nov 9, 2020
Merged

Migrate to pow #654

merged 32 commits into from
Nov 9, 2020

Conversation

eliknebel
Copy link
Contributor

This PR changes the authentication mechanics over to use the Pow library and adds email support. A full list of changes can be found in #622. To summarize:

  • Users can still register using supported social media provider or email
  • Social media providers have changed from google and facebook, to now use google and github
  • Users who register using email must verify their email address
  • Users can now request to reset their password, in which case they will receive and email with a password reset link
  • In development mode, "sent" emails can be viewed by going to https://localhost/dev/sent_emails. In production, email will be sent using Amazon SES
  • Additionally, a better view of unit test coverage has been added using coveralls and integrated into github. Every pull request will now include a link to the unit test coverage results

Closes #622

fix logo link path
resolve email issues related to ses
revise email templates, refactor mailers
@ThinkThoughtThunk
Copy link
Contributor

Wow, this is great. There's a lot here. The one thing I saw is that editing a page shows the "default" user in the curriculum view when under active edit. It looks like the entry.ex live view is set up correctly to use the user's "given name" so I'm not sure what the issue is, and I don't know if this would happen outside a local environment, but wanted to bring it up.

image

@eliknebel
Copy link
Contributor Author

That's an interesting one, I tried to recreate but was unsuccessful
Screen Shot 2020-11-06 at 5 53 36 PM

@ThinkThoughtThunk ThinkThoughtThunk merged commit c4e56bb into master Nov 9, 2020
@ThinkThoughtThunk ThinkThoughtThunk deleted the migrate-to-pow branch November 9, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade user auth to use Pow
2 participants