Add clang formatting checks for src/ files (bloomberg#51)

* add clang-format * clang format * Update .github/workflows/build.yaml Co-authored-by: Will Hoy <[email protected]> --------- Co-authored-by: Taylor Foxhall <[email protected]>
Simon-Sandrew · Aug 2, 2023 · 25ae31f · 25ae31f
1 parent 1563c99
commit 25ae31f
Show file tree

Hide file tree

Showing 26 changed files with 11,059 additions and 11,474 deletions.
diff --git a/.clang-format b/.clang-format
@@ -0,0 +1,45 @@
+BasedOnStyle: LLVM
+AlignConsecutiveAssignments: true
+AlignConsecutiveDeclarations: true
+AllowAllParametersOfDeclarationOnNextLine: false
+AllowAllArgumentsOnNextLine: false
+AllowShortCaseLabelsOnASingleLine: true
+AllowShortFunctionsOnASingleLine: InlineOnly
+AllowShortLambdasOnASingleLine: Empty
+AlwaysBreakTemplateDeclarations: Yes
+BinPackParameters: false
+BinPackArguments: false
+BreakBeforeBraces: Custom
+BraceWrapping:
+  AfterCaseLabel: false
+  AfterClass: false
+  AfterControlStatement: Never
+  AfterEnum: false
+  AfterFunction: true
+  AfterNamespace: false
+  AfterObjCDeclaration: false
+  AfterStruct: false
+  AfterUnion: false
+  AfterExternBlock: false
+  BeforeCatch: true
+  BeforeElse: true
+  IndentBraces: false
+  SplitEmptyFunction: true
+  SplitEmptyRecord: true
+  SplitEmptyNamespace: true
+BreakConstructorInitializers: BeforeComma
+ColumnLimit: 79
+ConstructorInitializerAllOnOneLineOrOnePerLine: false
+ConstructorInitializerIndentWidth: 0
+FixNamespaceComments: false
+IndentWidth: 4
+KeepEmptyLinesAtTheStartOfBlocks: false
+PenaltyBreakBeforeFirstCallParameter: 25
+PenaltyBreakAssignment: 100
+PointerAlignment: Left
+ReflowComments: true
+SortIncludes: CaseInsensitive
+SpaceBeforeCpp11BracedList: false
+SpacesBeforeTrailingComments: 2
+Standard: Cpp03
+TabWidth: 4
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -55,18 +55,30 @@ jobs:
           cd cmake.bld/Linux
           ctest -E mwcsys_executil.t --output-on-failure
 
-  lint_and_docs:
-    name: "Lint and Docs"
+  Documentation:
+    name: "Documentation"
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
       - name: Set up dependencies
         run: |
           sudo apt-get update
-          sudo apt-get install -qy clang-format git doxygen
-      - name: Lint sources
-        run: |
-          git clang-format
+          sudo apt-get install -qy doxygen
       - name: Build docs
         run: |
           doxygen Doxyfile
+  
+  formatting-check:
+    name: Formatting Check
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        path:
+          - 'src'
+    steps:
+      - uses: actions/checkout@v3
+      - name: Run clang-format style check for C/C++/Protobuf programs.
+        uses: jidicula/[email protected]
+        with:
+          clang-format-version: '14'
+          check-path: ${{ matrix.path }}
diff --git a/src/groups/bmq/bmqa/bmqa_mocksession.cpp b/src/groups/bmq/bmqa/bmqa_mocksession.cpp
@@ -955,14 +955,14 @@ MockSession::MockSession(const bmqt::SessionOptions& options,
                                     bdlf::PlaceHolders::_2,
                                     bdlf::PlaceHolders::_3))
 , d_lastQueueId(0)
-, d_corrIdContainer_sp(new(*bslma::Default::allocator(allocator))
+, d_corrIdContainer_sp(new (*bslma::Default::allocator(allocator))
                            bmqimp::MessageCorrelationIdContainer(
                                bslma::Default::allocator(allocator)),
                        bslma::Default::allocator(allocator))
 , d_postedEvents(bslma::Default::allocator(allocator))
 , d_rootStatContext(mwcst::StatContextConfiguration("MockSession", allocator),
                     allocator)
-, d_queuesStats_sp(new(*bslma::Default::allocator(allocator))
+, d_queuesStats_sp(new (*bslma::Default::allocator(allocator))
                        bmqimp::Stat(bslma::Default::allocator(allocator)),
                    bslma::Default::allocator(allocator))
 , d_sessionOptions(options, allocator)
@@ -998,14 +998,14 @@ MockSession::MockSession(bslma::ManagedPtr<SessionEventHandler> eventHandler,
                                     bdlf::PlaceHolders::_2,
                                     bdlf::PlaceHolders::_3))
 , d_lastQueueId(0)
-, d_corrIdContainer_sp(new(*bslma::Default::allocator(allocator))
+, d_corrIdContainer_sp(new (*bslma::Default::allocator(allocator))
                            bmqimp::MessageCorrelationIdContainer(
                                bslma::Default::allocator(allocator)),
                        bslma::Default::allocator(allocator))
 , d_postedEvents(bslma::Default::allocator(allocator))
 , d_rootStatContext(mwcst::StatContextConfiguration("MockSession", allocator),
                     allocator)
-, d_queuesStats_sp(new(*bslma::Default::allocator(allocator))
+, d_queuesStats_sp(new (*bslma::Default::allocator(allocator))
                        bmqimp::Stat(bslma::Default::allocator(allocator)),
                    bslma::Default::allocator(allocator))
 , d_sessionOptions(options, allocator)

diff --git a/src/groups/bmq/bmqa/bmqa_mocksession.t.cpp b/src/groups/bmq/bmqa/bmqa_mocksession.t.cpp
@@ -68,7 +68,8 @@ using namespace bsl;
 
 /// Mapping class.  Will be partially specialized below.
 template <typename T>
-struct ResultRegistry {};
+struct ResultRegistry {
+};
 
 /// Partial specialization for mapping to `bmqa::OpenQueueStatus`.
 template <>

diff --git a/src/groups/bmq/bmqimp/bmqimp_brokersession.cpp b/src/groups/bmq/bmqimp/bmqimp_brokersession.cpp
@@ -1350,7 +1350,7 @@ BrokerSession::QueueFsm::QueueFsm(BrokerSession& session)
     typedef QueueState    S;
     typedef QueueFsmEvent E;
     QueueStateTransition  table[] = {
-        // current state           event              new state
+         // current state           event              new state
         {S::e_CLOSED, E::e_OPEN_CMD, S::e_OPENING_OPN},
         //
         {S::e_OPENING_OPN, E::e_RESP_OK, S::e_OPENING_CFG},

diff --git a/src/groups/bmq/bmqp/bmqp_queueid.cpp b/src/groups/bmq/bmqp/bmqp_queueid.cpp
@@ -30,7 +30,8 @@ namespace bsl {
 // need to have 'is_fundamental' trait.
 
 template <>
-struct is_fundamental<BloombergLP::bmqp::QueueId::QueueIdInt> : true_type {};
+struct is_fundamental<BloombergLP::bmqp::QueueId::QueueIdInt> : true_type {
+};
 
 template <>
 struct is_fundamental<BloombergLP::bmqp::QueueId::SubQueueIdInt> : true_type {

diff --git a/src/groups/mqb/mqbblp/mqbblp_clusterorchestrator.cpp b/src/groups/mqb/mqbblp/mqbblp_clusterorchestrator.cpp
@@ -576,7 +576,7 @@ ClusterOrchestrator::ClusterOrchestrator(
 , d_stateManager_mp(
       clusterConfig.clusterAttributes().isFSMWorkflow()
           ? static_cast<mqbi::ClusterStateManager*>(
-                new(*d_allocator_p) mqbc::ClusterStateManager(
+                new (*d_allocator_p) mqbc::ClusterStateManager(
                     clusterConfig,
                     d_cluster_p,
                     d_clusterData_p,
@@ -595,7 +595,7 @@ ClusterOrchestrator::ClusterOrchestrator(
                     k_WATCHDOG_TIMEOUT_DURATION,
                     d_allocators.get("ClusterStateManager")))
           : static_cast<mqbi::ClusterStateManager*>(
-                new(*d_allocator_p) ClusterStateManager(
+                new (*d_allocator_p) ClusterStateManager(
                     clusterConfig,
                     d_cluster_p,
                     d_clusterData_p,

diff --git a/src/groups/mqb/mqbblp/mqbblp_clusterqueuehelper.cpp b/src/groups/mqb/mqbblp/mqbblp_clusterqueuehelper.cpp
@@ -1948,7 +1948,7 @@ bool ClusterQueueHelper::createQueue(
                   << context.d_handleParameters << "]";
 
     mqbi::Cluster::OpenQueueConfirmationCookie confirmationCookie(
-        new (*d_allocator_p) mqbi::QueueHandle * (0),
+        new (*d_allocator_p) mqbi::QueueHandle*(0),
         bdlf::BindUtil::bind(
             &ClusterQueueHelper::onOpenQueueConfirmationCookieReleased,
             this,

diff --git a/src/groups/mqb/mqbblp/mqbblp_messagegroupidmanager.cpp b/src/groups/mqb/mqbblp/mqbblp_messagegroupidmanager.cpp
@@ -624,7 +624,7 @@ MessageGroupIdManager::MessageGroupIdManager(const Time&       timeout,
 , d_timeout(timeout)
 , d_maxMsgGroupIds(maxMsgGroupIds)
 , d_rebalance(rebalance)
-, d_index(new(*allocator) Index(allocator), allocator)
+, d_index(new (*allocator) Index(allocator), allocator)
 {
 }
 

diff --git a/src/groups/mqb/mqbblp/mqbblp_queueconsumptionmonitor.t.cpp b/src/groups/mqb/mqbblp/mqbblp_queueconsumptionmonitor.t.cpp
@@ -81,7 +81,7 @@ struct ClientContext {
 
 ClientContext::ClientContext()
 : d_dispatcherClient(s_allocator_p)
-, d_requesterContext_sp(new(*s_allocator_p)
+, d_requesterContext_sp(new (*s_allocator_p)
                             mqbi::QueueHandleRequesterContext(s_allocator_p),
                         s_allocator_p)
 {

diff --git a/src/groups/mqb/mqbblp/mqbblp_queueengineutil.cpp b/src/groups/mqb/mqbblp/mqbblp_queueengineutil.cpp
@@ -805,7 +805,7 @@ QueueEngineUtil_AppState::QueueEngineUtil_AppState(
     const mqbu::StorageKey&                  appKey,
     bslma::Allocator*                        allocator)
 : d_storageIter_mp(iterator)
-, d_routing_sp(new(*allocator) Routers::AppContext(queueContext, allocator),
+, d_routing_sp(new (*allocator) Routers::AppContext(queueContext, allocator),
                allocator)
 , d_redeliveryList(allocator)
 , d_putAsideList(allocator)

diff --git a/src/groups/mqb/mqbblp/mqbblp_queuehandle.h b/src/groups/mqb/mqbblp/mqbblp_queuehandle.h
@@ -665,7 +665,7 @@ inline QueueHandle::Downstream::Downstream(const bsl::string& appId,
                                            bslma::Allocator* allocator_p)
 : d_appId(appId)
 , d_upstreamSubQueueId(upstreamSubQueueId)
-, d_data(new(*allocator_p)
+, d_data(new (*allocator_p)
              mqbi::QueueHandle::UnconfirmedMessageInfoMap(allocator_p),
          allocator_p)
 {

diff --git a/src/groups/mqb/mqbblp/mqbblp_queuehandlecatalog.cpp b/src/groups/mqb/mqbblp/mqbblp_queuehandlecatalog.cpp
@@ -122,7 +122,7 @@ void QueueHandleCatalog::queueHandleDeleter(mqbi::QueueHandle* handle)
 QueueHandleCatalog::QueueHandleCatalog(mqbi::Queue*      queue,
                                        bslma::Allocator* allocator)
 : d_queue_p(queue)
-, d_handleFactory_mp(new(*allocator) DefaultHandleFactory(), allocator)
+, d_handleFactory_mp(new (*allocator) DefaultHandleFactory(), allocator)
 , d_handles(allocator)
 , d_allocator_p(allocator)
 {

diff --git a/src/groups/mqb/mqbblp/mqbblp_queuesessionmanager.cpp b/src/groups/mqb/mqbblp/mqbblp_queuesessionmanager.cpp
@@ -525,8 +525,8 @@ QueueSessionManager::QueueSessionManager(
 , d_domainFactory_p(domainFactory)
 , d_allocator_p(allocator)
 , d_shutdownInProgress(false)
-, d_validator_sp(new(*allocator) mwcu::AtomicValidator(), allocator)
-, d_requesterContext_sp(new(*allocator)
+, d_validator_sp(new (*allocator) mwcu::AtomicValidator(), allocator)
+, d_requesterContext_sp(new (*allocator)
                             mqbi::QueueHandleRequesterContext(allocator),
                         allocator)
 {

diff --git a/src/groups/mqb/mqbblp/mqbblp_routers.h b/src/groups/mqb/mqbblp/mqbblp_routers.h
@@ -832,7 +832,7 @@ inline Routers::QueueRoutingContext::QueueRoutingContext(
 : d_expressions(allocator)
 , d_nextSubscriptionId(0)
 , d_groupIds(allocator)
-, d_preader(new(*allocator) MessagePropertiesReader(schemaLearner, allocator),
+, d_preader(new (*allocator) MessagePropertiesReader(schemaLearner, allocator),
             allocator)
 , d_evaluationContext(0, allocator)
 , d_allocator_p(allocator)

diff --git a/src/groups/mqb/mqbblp/mqbblp_routers.t.cpp b/src/groups/mqb/mqbblp/mqbblp_routers.t.cpp
@@ -76,7 +76,7 @@ struct TestStorage {
                 allocator)
     , d_iterator(d_storage.getIterator(mqbu::StorageKey()))
     , d_bufferFactory(32, allocator)
-    , d_queue_sp(new(*allocator) mqbmock::Queue(0, allocator), allocator)
+    , d_queue_sp(new (*allocator) mqbmock::Queue(0, allocator), allocator)
     , d_allocator_p(allocator)
 
     {

diff --git a/src/groups/mqb/mqbc/mqbc_clusternodesession.cpp b/src/groups/mqb/mqbc/mqbc_clusternodesession.cpp
@@ -42,7 +42,7 @@ ClusterNodeSession::ClusterNodeSession(
 , d_clusterNode_p(netNode)
 , d_peerInstanceId(0)  // There is no invalid value for this field
 , d_queueHandleRequesterContext_sp(
-      new(*allocator) mqbi::QueueHandleRequesterContext(allocator),
+      new (*allocator) mqbi::QueueHandleRequesterContext(allocator),
       allocator)
 , d_nodeStatus(bmqp_ctrlmsg::NodeStatus::E_UNAVAILABLE)  // See note in ctor
 , d_statContext_sp()