configuration: improve getopt_long error reporting #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, in case of an unrecognized option we get two error messages. The first is printed by getopt_long and the second is printed by kcov error handler. An additional issue is that the kcov error handler prints optopt, but this value is 0 (NULL character) in this case. Improve the error handler by using optind to get the offending option. This is done in a separate switch case, instead of the default case. Disable getopt error messages by setting opterr to 0. Configure getopt_long to report a missing argument using a different error code, so that this can be handled in a separate switch case. Note however that this error is only reported when the option is the last argument. Update the basic.TooFewArguments and basic.WrongArguments test cases.
|
The new test should probably be skipped, since it is preventing full testing. For the next PRs I plan to improve the Python code running the test suite, so the tests should work without issues. UPDATE |
|
That's a nice improvement of the option parsing, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in case of an unrecognized option we get two error messages. The first is printed by
getopt_longand the second is printed bykcoverror handler.An additional issue is that the
kcoverror handler printsoptopt, but this value is0(NULL character) in this case.Improve the error handler by using
optindto get the offending option. This is done in a separate switch case, instead of the default case. Disablegetopterror messages by settingopterrto 0.Configure
getopt_longto report a missing argument using a different error code, so that this can be handled in a separate switch case. Note however that this error is only reported when the option is the last argument.Update the
basic.TooFewArgumentsandbasic.WrongArgumentstest cases.TODO
Print useful error message in case of an invalid option argument. This PR will not implement it.