Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARGG-1343: add speaker mute icon #94

Merged
merged 9 commits into from
Nov 11, 2024
Merged

Conversation

Parisistan
Copy link
Contributor

  • We are updating the speaker icon.
  • Plus adding a speaker-mute icon.

@Parisistan Parisistan added the minor Used for minor changes label Nov 7, 2024
@Parisistan Parisistan marked this pull request as ready for review November 7, 2024 12:43
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right? Looks like the large one has become small but the dimensions displayed are confusing because it says the original is 0x0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the file based on the files that were sent in the request. for lg:
speaker-mute
speaker

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And for sm:
speaker-mute
speaker

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also have in mind @Sybsw that there was no original speaker-mute. This was just being added now.

@Parisistan Parisistan requested a review from Sybsw November 7, 2024 15:23
@Parisistan Parisistan merged commit 8b3419e into main Nov 11, 2024
3 checks passed
@Parisistan Parisistan deleted the ARGG-1343-update_speaker_icon_svg branch November 11, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Used for minor changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants