19.0.0

What’s Changed

Breaking

• Bump @typescript-eslint/eslint-plugin from 7.12.0 to 8.3.0 (#775) @dependabot

Breaking changes that might affect consumers of ECS:

Rules breaking changes

• see typescript-eslint changelog here
• see typescript-eslint rule config changes in a table format and add any comments to the thread if you have feedback https://github.com/typescript-eslint/typescript-eslint/discussions/8914

Node.js support range was changed from ^18.18.0 || >=20.0.0 to ^18.18.0 || ^20.9.0 || >=21.1.0
TypeScript support range was changed from >=4.7.4 <5.5.0 to >=4.8.4 <5.5.0

Added

• Bump eslint-plugin-import from 2.29.1 to 2.31.0 (#781) @dependabot

Fixed

• Bump cross-spawn from 7.0.3 to 7.0.6 (#789) @dependabot

18.3.0

What’s Changed

Added

• Bump eslint-plugin-jsx-a11y from 6.8.0 to 6.9.0 (#746) @dependabot
• Bump eslint-plugin-jest from 28.6.0 to 28.8.0 (#770) @dependabot
• Bump @babel/core from 7.24.0 to 7.25.2 (#769) @dependabot
• Bump @typescript-eslint/parser from 7.12.0 to 7.18.0 (#766) @dependabot
• Bump husky from 9.0.11 to 9.1.4 (#764) @dependabot
• Bump eslint-plugin-react from 7.34.0 to 7.35.0 (#759) @dependabot
• Bump @babel/eslint-parser from 7.24.1 to 7.25.1 (#760) @dependabot
• Bump eslint-plugin-prettier from 5.1.3 to 5.2.1 (#757) @dependabot

Fixed

• Bump micromatch and lint-staged (#774) @dependabot

Dependency updates

• Bump micromatch and lint-staged (#774) @dependabot
• Bump eslint-plugin-jsx-a11y from 6.8.0 to 6.9.0 (#746) @dependabot
• Bump eslint-plugin-jest from 28.6.0 to 28.8.0 (#770) @dependabot
• Bump @babel/core from 7.24.0 to 7.25.2 (#769) @dependabot
• Bump @typescript-eslint/parser from 7.12.0 to 7.18.0 (#766) @dependabot
• Bump husky from 9.0.11 to 9.1.4 (#764) @dependabot
• Bump eslint-plugin-react from 7.34.0 to 7.35.0 (#759) @dependabot
• Bump @babel/eslint-parser from 7.24.1 to 7.25.1 (#760) @dependabot
• Bump eslint-plugin-prettier from 5.1.3 to 5.2.1 (#757) @dependabot

18.2.1

What’s Changed

Fixed

• Updated @skyscanner/eslint-plugin-rules (#754) @amburrrshand

18.2.0

What’s Changed

Added

• Bump eslint-plugin-rules to v1.2.0 (#741) @youngji0827

An optional new rule to enforce adding Jira ticket references as part of TODO / FIXME comments is now available.

To turn this on add the below to your linting config:

// All TODO/FIXME's should have a JIRA reference.
'@skyscanner/rules/no-jira-todo': 'error',

Updated

• Bump eslint-plugin-jest from 28.5.0 to 28.6.0 (#739) @dependabot
• Bump @typescript-eslint/eslint-plugin from 7.9.0 to 7.12.0 (#738) @dependabot
• Bump @typescript-eslint/parser from 7.8.0 to 7.12.0 (#737) @dependabot
• Bump prettier from 3.2.5 to 3.3.1 (#736) @dependabot
• Bump eslint-plugin-jest from 28.2.0 to 28.5.0 (#730) @dependabot
• Bump @typescript-eslint/eslint-plugin from 7.8.0 to 7.9.0 (#728) @dependabot

18.1.0

What’s Changed

Breaking

• Bump eslint-plugin-jest from 27.9.0 to 28.2.0 (#717) @dependabot
• Bump eslint-plugin-sort-destructure-keys from 1.5.0 to 2.0.0 (#724) @dependabot

Added

• Bump @typescript-eslint/eslint-plugin from 7.5.0 to 7.8.0 (#726) @dependabot
• Bump @typescript-eslint/parser from 7.5.0 to 7.8.0 (#727) @dependabot

Dependency updates

• Bump eslint-plugin-jest from 27.9.0 to 28.2.0 (#717) @dependabot
• Bump eslint-plugin-sort-destructure-keys from 1.5.0 to 2.0.0 (#724) @dependabot
• Bump @typescript-eslint/eslint-plugin from 7.5.0 to 7.8.0 (#726) @dependabot
• Bump @typescript-eslint/parser from 7.5.0 to 7.8.0 (#727) @dependabot

18.0.0

What’s Changed

@typescript-eslint/parser changes

@typescript-eslint/parser has been updated from 6.21.0 to 7.1.0 release notes. As a result, to maintain compatibility with this package you may need to make modifications within your codebase:

• ⚠️ Dropping support for Node 16, 19, and Node 18 versions prior to 18.18.0.
• ⚠️ Update the TypeScript peer dependency requirement to >=4.7.4.
• ✅ eslint is managed via eslint-config-skyscanner and is an acceptable version. No change required from consumers.

Added

• [LOOM-1339]: Added @skyscanner/rules/forbid-component-props from @skyscanner/eslint-plugin-rules (#714) @mungodewar
• [NOJIRA]: Update engine & npm (#718) @mungodewar

Dependency updates

• Bump @babel/preset-react from 7.23.3 to 7.24.1 (#709) @dependabot
• Bump @babel/eslint-parser from 7.23.10 to 7.24.1 (#710) @dependabot
• Bump @typescript-eslint/eslint-plugin from 7.1.0 to 7.5.0 (#715) @dependabot
• Bump @typescript-eslint/parser from 7.1.0 to 7.5.0 (#716) @dependabot
• Bump eslint-plugin-react from 7.33.2 to 7.34.0 (#704) @dependabot
• Bump @typescript-eslint/parser from 6.21.0 to 7.1.0 (#703) @dependabot
• Bump eslint-plugin-jest from 27.6.3 to 27.9.0 (#700) @dependabot
• Bump eslint from 8.56.0 to 8.57.0 (#702) @dependabot
• Bump @typescript-eslint/eslint-plugin from 6.20.0 to 6.21.0 (#696) @dependabot
• Bump @typescript-eslint/parser from 6.20.0 to 6.21.0 (#697) @dependabot
• Bump @typescript-eslint/eslint-plugin from 6.19.0 to 6.20.0 (#695) @dependabot
• Bump @typescript-eslint/parser from 6.19.0 to 6.20.0 (#694) @dependabot

17.4.0

What’s Changed

ℹ️ If you were using the skyscanner-no-axios/no-axios rule, you will need to change it to @skyscanner/rules/no-axios due to changes introduced in ARGG-946.

While this would normally imply a major release, the package updates have been broken since we introduced skyscanner-no-axios/no-axios. Therefore this change will be treated as a bug fix.

Added

• Bump @typescript-eslint/parser from 6.18.1 to 6.19.0 (#691) @dependabot
• ARGG-946 Add @skyscanner/[email protected] to dependencies (#692) @soulcheck
• Bump @typescript-eslint/eslint-plugin from 6.18.0 to 6.19.0 (#689) @dependabot
• Bump prettier from 3.1.1 to 3.2.2 (#684) @dependabot

Fixed

• Bump prettier from 3.2.2 to 3.2.4 (#688) @dependabot
• Bump eslint-plugin-jest from 27.6.1 to 27.6.3 (#686) @dependabot
• Bump @typescript-eslint/parser from 6.18.0 to 6.18.1 (#685) @dependabot
• Bump eslint-plugin-prettier from 5.1.2 to 5.1.3 (#683) @dependabot

Dependency updates

• Bump @typescript-eslint/parser from 6.18.1 to 6.19.0 (#691) @dependabot
• Bump @typescript-eslint/eslint-plugin from 6.18.0 to 6.19.0 (#689) @dependabot
• Bump prettier from 3.2.2 to 3.2.4 (#688) @dependabot
• Bump eslint-plugin-jest from 27.6.1 to 27.6.3 (#686) @dependabot
• Bump @typescript-eslint/parser from 6.18.0 to 6.18.1 (#685) @dependabot
• Bump prettier from 3.1.1 to 3.2.2 (#684) @dependabot
• Bump eslint-plugin-prettier from 5.1.2 to 5.1.3 (#683) @dependabot

17.3.0

What’s Changed

Added

• Bump eslint from 8.55.0 to 8.56.0 (#669) @dependabot
• Bump @typescript-eslint/parser from 6.14.0 to 6.18.0 (#679) @dependabot
• Bump @typescript-eslint/eslint-plugin from 6.13.2 to 6.18.0 (#681) @dependabot
• Bump eslint-plugin-prettier from 5.0.1 to 5.1.2 (#674) @dependabot

Fixed

• Bump eslint-plugin-jest from 27.6.0 to 27.6.1 (#680) @dependabot
• Remove no-axios rule peer dependency on eslint (#682) @soulcheck
• Bump eslint-plugin-import from 2.29.0 to 2.29.1 (#668) @dependabot

Dependency updates

• Bump eslint from 8.55.0 to 8.56.0 (#669) @dependabot
• Bump @typescript-eslint/parser from 6.14.0 to 6.18.0 (#679) @dependabot
• Bump eslint-plugin-jest from 27.6.0 to 27.6.1 (#680) @dependabot
• Bump @typescript-eslint/eslint-plugin from 6.13.2 to 6.18.0 (#681) @dependabot
• Bump eslint-plugin-import from 2.29.0 to 2.29.1 (#668) @dependabot
• Bump eslint-plugin-prettier from 5.0.1 to 5.1.2 (#674) @dependabot

17.2.0

What’s Changed

Added

• Bump @typescript-eslint/parser from 6.13.1 to 6.14.0 (#667) @dependabot
• Bump eslint from 8.54.0 to 8.55.0 (#659) @dependabot
• Bump @typescript-eslint/eslint-plugin from 6.12.0 to 6.13.2 (#664) @dependabot
• Bump eslint-config-prettier from 9.0.0 to 9.1.0 (#662) @dependabot
• Bump lint-staged from 15.1.0 to 15.2.0 (#661) @dependabot

Fixed

• Test if dynamic import argument is a string (#666) @soulcheck
• Bump prettier from 3.1.0 to 3.1.1 (#663) @dependabot

Dependency updates

• Bump @typescript-eslint/parser from 6.13.1 to 6.14.0 (#667) @dependabot
• Bump eslint from 8.54.0 to 8.55.0 (#659) @dependabot
• Bump @typescript-eslint/eslint-plugin from 6.12.0 to 6.13.2 (#664) @dependabot
• Bump prettier from 3.1.0 to 3.1.1 (#663) @dependabot
• Bump eslint-config-prettier from 9.0.0 to 9.1.0 (#662) @dependabot
• Bump lint-staged from 15.1.0 to 15.2.0 (#661) @dependabot

17.1.0

What’s Changed

Added

• [ARGG-857] Add rule forbidding the use of axios library (#656) @soulcheck
  Axios errors, when logged, can lead to sensitive data leaks as they include headers and other pieces of sensitive data.
  This change adds a rule that will throw an error if axios is imported or required. We encourage users to find safer alternatives to axios.
  The rule can be configured to be a warning or switched off completely on a per-repository basis.

Dependency updates

• Bump @babel/core from 7.23.2 to 7.23.5 (#658) @dependabot
• Bump @babel/eslint-parser from 7.22.15 to 7.23.3 (#645) @dependabot
• Bump @babel/preset-react from 7.22.15 to 7.23.3 (#648) @dependabot
• Bump @typescript-eslint/eslint-plugin from 6.10.0 to 6.12.0 (#655) @dependabot
• Bump @typescript-eslint/eslint-plugin from 6.7.2 to 6.10.0 (#643) @dependabot
• Bump @typescript-eslint/parser from 6.7.5 to 6.9.1 (#639) @dependabot
• Bump @typescript-eslint/parser from 6.9.1 to 6.13.1 (#657) @dependabot
• Bump eslint from 8.52.0 to 8.53.0 (#642) @dependabot
• Bump eslint from 8.53.0 to 8.54.0 (#653) @dependabot
• Bump eslint-plugin-jsx-a11y from 6.7.1 to 6.8.0 (#641) @dependabot
• Bump lint-staged from 15.0.2 to 15.1.0 (#647) @dependabot
• Bump prettier from 3.0.3 to 3.1.0 (#649) @dependabot