Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wav Support for Audio Uploads #66

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Add Wav Support for Audio Uploads #66

merged 2 commits into from
Jan 13, 2025

Conversation

Zidiam
Copy link
Contributor

@Zidiam Zidiam commented Jan 13, 2025

This pull request adds the Wav variant to the AudioKind enum in Asphalt's asset handling, enabling .wav audio files to be properly recognized and mapped to CloudAssetType::AudioWav. The primary changes include:

  • Extending the AudioKind enum to support Wav.
  • Matching .wav in the Asset::new constructor, so Asphalt no longer errors on unknown extension.
  • Mapping AudioKind::Wav to CloudAssetType::AudioWav, allowing the upload process to treat .wav like any other supported audio format.

With this addition, .wav files can now be uploaded as high-fidelity audio assets through Asphalt without manual format conversion or “unknown extension” errors.

@Zidiam Zidiam changed the title Add Wave Support for Audio Uploads Add Wav Support for Audio Uploads Jan 13, 2025
@Sleitnick Sleitnick merged commit 4b8de7a into Sleitnick:main Jan 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants