-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoformat documentation examples and update README #9
Conversation
As mentioned in [1] the documentation example could use some autoformatting, and recent API changes have to be propagated into the README too. [1]: Smithay#4 (comment)
Thanks! |
@MarijnS95, I'm on a way to adopt another approach in my crates. I simply used @Drakulix, I don't sure how such approach applicable here but looks like much simpler. |
@katyo That seems like a pretty cool idea! Most READMEs are partial duplicates of the documentation header and apparently it even supports templates to generate the readme. And it strips I'll have to try this out some time, maybe this GBM crate with a relatively slim readme is a good place to start :) |
Check with our documentation, unfortunately it doesn't strip empty comment lines with EDIT: That'll be fixed by webern/cargo-readme#67. |
Based on the suggestion from @katyo in [1] and implementation in [2]. [1]: Smithay#9 (comment) [2]: https://github.com/katyo/aubio-rs/pull/18/files
Based on the suggestion from @katyo in [1] and implementation in [2]. [1]: Smithay#9 (comment) [2]: https://github.com/katyo/aubio-rs/pull/18/files
Based on the suggestion from @katyo in [1] and implementation in [2]. [1]: Smithay#9 (comment) [2]: https://github.com/katyo/aubio-rs/pull/18/files
I really like that idea. 👍 |
Based on the suggestion from @katyo in [1] and implementation in [2]. [1]: Smithay#9 (comment) [2]: https://github.com/katyo/aubio-rs/pull/18/files
As mentioned in 1 the documentation example could use some autoformatting, and recent API changes have to be propagated into the README too.
I'm curious if we should just paste the full working example in
README
, that's much clearer IMO, or refernce. @katyo given your CI efforts you might like https://docs.rs/doc-comment/, a crate that (build)tests the documentation in arbitrary markdown files likeREADME.md
frombuild.rs
. If we put a fully working example here we can also make sure that it stays in a compiling state :)