Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve upgrade initializer call #1010

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Improve upgrade initializer call #1010

merged 2 commits into from
Nov 16, 2023

Conversation

vgeddes
Copy link
Collaborator

@vgeddes vgeddes commented Nov 15, 2023

Minor initializer cleanups

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df81476) 80.98% compared to head (b304d67) 80.97%.
Report is 2 commits behind head on main.

❗ Current head b304d67 differs from pull request most recent head c65a3ec. Consider uploading reports for the commit c65a3ec to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1010      +/-   ##
==========================================
- Coverage   80.98%   80.97%   -0.01%     
==========================================
  Files          52       52              
  Lines        2161     2160       -1     
  Branches       72       71       -1     
==========================================
- Hits         1750     1749       -1     
  Misses        396      396              
  Partials       15       15              
Flag Coverage Δ
solidity 80.82% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alistair-singh alistair-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vgeddes vgeddes merged commit 68c6a66 into main Nov 16, 2023
1 check passed
@vgeddes vgeddes deleted the upgrade-initializer branch November 16, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants