INFO-4: Code optimization/simplification #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
==========================================
+ Coverage 81.00% 81.06% +0.06%
==========================================
Files 52 52
Lines 2153 2150 -3
Branches 72 70 -2
==========================================
- Hits 1744 1743 -1
+ Misses 394 392 -2
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alistair-singh
force-pushed
the
alistair/audit-info-4-code-optimization
branch
from
584a44d to
1c7b049
Compare
vgeddes
reviewed
Nov 27, 2023
| items[i].payloadID, | ||
| ScaleCodec.checkedEncodeCompactU32(uint32(items[i].data.length)), | ||
| items[i].data | ||
| payload, items[i].payloadID, ScaleCodec.checkedEncodeCompactU32(items[i].data.length), items[i].data |
There was a problem hiding this comment.
It was easier to read this when each item was on its own line
There was a problem hiding this comment.
forge fmt reverts to this form.
| } | ||
|
|
||
| function encodeDigestItem(DigestItem calldata digestItem) internal pure returns (bytes memory) { | ||
| if (digestItem.kind == DIGEST_ITEM_PRERUNTIME) { | ||
| if ( | ||
| digestItem.kind == DIGEST_ITEM_PRERUNTIME || digestItem.kind == DIGEST_ITEM_CONSENSUS |
There was a problem hiding this comment.
lets have each test on its line if the formatter allows it.
There was a problem hiding this comment.
forge fmt does not allow it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: SNO-757