LOW-3: Missing input validation #1025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1025 +/- ##
==========================================
+ Coverage 81.06% 81.08% +0.01%
==========================================
Files 52 52
Lines 2150 2152 +2
Branches 67 68 +1
==========================================
+ Hits 1743 1745 +2
Misses 392 392
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alistair-singh
force-pushed
the
alistair/low-3-missing-validation
branch
from
e37aa1e to
db994ef
Compare
contracts/src/BeefyClient.sol
Outdated
| @@ -215,6 +216,9 @@ contract BeefyClient { | |||
| ValidatorSet memory _initialValidatorSet, | |||
| ValidatorSet memory _nextValidatorSet | |||
| ) { | |||
| if (_nextValidatorSet.id != _initialValidatorSet.id + 1) { | |||
| revert InvalidValidatorSetData(); | |||
There was a problem hiding this comment.
Can just revert() here without raising a custom exception. I don't want to add a custom exception InvalidValidatorSetData which may never ever be used.
There was a problem hiding this comment.
Addressed in 9fd1195.
There was a problem hiding this comment.
Nit, would prefer a string that looks more robotic: invalid-constructor-params
There was a problem hiding this comment.
Quick fix: 87d87cc.
alistair-singh
force-pushed
the
alistair/low-3-missing-validation
branch
from
87d87cc to
cd3e57c
Compare
Resolves: SNO-753
Extra merkle proof validations from the audit issue are not addressed.