Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code coverage #1143

Merged
merged 7 commits into from
Feb 22, 2024
Merged

Fix code coverage #1143

merged 7 commits into from
Feb 22, 2024

Conversation

claravanstaden
Copy link
Contributor

Fixes the coverage config file not to include the parachain. States on the readme the coverage is for contracts.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec6efea) 49.66% compared to head (9fd716f) 80.71%.
Report is 8 commits behind head on main.

❗ Current head 9fd716f differs from pull request most recent head d7901f9. Consider uploading reports for the commit d7901f9 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1143       +/-   ##
===========================================
+ Coverage   49.66%   80.71%   +31.04%     
===========================================
  Files          63       12       -51     
  Lines        3707      394     -3313     
  Branches       72       72               
===========================================
- Hits         1841      318     -1523     
+ Misses       1849       59     -1790     
  Partials       17       17               
Flag Coverage Δ
rust ?
solidity 80.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@claravanstaden claravanstaden marked this pull request as ready for review February 20, 2024 10:19
@claravanstaden claravanstaden requested review from vgeddes, yrong and alistair-singh and removed request for vgeddes February 20, 2024 10:19
@vgeddes
Copy link
Collaborator

vgeddes commented Feb 20, 2024

Ah I would remove the note that the coverage is for contracts only. It's in a very prominent position at the start of the readme, yet is not very important.

Also there is some kind of markup error - see the bullet points in the image below. Are you trying to use some special markup?

Capture-2024-02-20-182414

@claravanstaden
Copy link
Contributor Author

@vgeddes I added an asterisk to indicate a special note about the coverage. 😂 I see that's not clear, I'll remove it.

Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@claravanstaden claravanstaden merged commit 08344c7 into main Feb 22, 2024
2 checks passed
@claravanstaden claravanstaden deleted the fix-coverage branch February 22, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants