Add fee multiplier to protocol #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1161 +/- ##
==========================================
- Coverage 78.92% 77.83% -1.10%
==========================================
Files 13 14 +1
Lines 408 415 +7
Branches 74 76 +2
==========================================
+ Hits 322 323 +1
- Misses 69 75 +6
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
claravanstaden
approved these changes
Mar 20, 2024
Co-authored-by: Alistair Singh <[email protected]>
alistair-singh
approved these changes
Mar 21, 2024
claravanstaden
pushed a commit
that referenced
this pull request
Apr 5, 2024
* Add fee multiplier * The base fee and exchange rate should be multiplied separately * Add FEE_MULTIPLIER to E2E config * Update web/packages/test/scripts/set-env.sh Co-authored-by: Alistair Singh <[email protected]> * Make multiplier non-linear * Add gateway upgrade for Rococo --------- Co-authored-by: Alistair Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since our system is currently governed by static exchange rates, we need to add a safety buffer to the calculated fees.
This ensures that if exchange rates or gas prices fluctuate, users pay enough fees to cover costs.
Companion PR: Snowfork/polkadot-sdk#127