Refactor proxy with diamond pattern #1162
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When implementing transfer polkadot assets it seems the
Gateway
code size exceeds 24576 bytes.Considering more features(e.g. Transacts) will be added soon, a single Gateway with all interfaces may not be ideal. So in this PR we change the proxy pattern from the previous EIP-1967 to EIP-2535(the diamond way) and split outbound interfaces to a separate contract(facet).
Though it solves the issue of the contract size limit it's not perfect, it costs more gas and is more complicated.