Separate endpoint for beacon state #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claravanstaden
commented
May 6, 2024
| @@ -398,7 +400,7 @@ func (b *BeaconClient) GetLatestFinalizedUpdate() (LatestFinalisedUpdateResponse | |||
|
|
|||
| func (b *BeaconClient) GetBeaconState(stateIdOrSlot string) ([]byte, error) { | |||
| var data []byte | |||
| req, err := http.NewRequest("GET", fmt.Sprintf("%s/eth/v2/debug/beacon/states/%s", b.endpoint, stateIdOrSlot), nil) | |||
| req, err := http.NewRequest("GET", fmt.Sprintf("%s/eth/v2/debug/beacon/states/%s", b.stateEndpoint, stateIdOrSlot), nil) | |||
There was a problem hiding this comment.
This is the main change.
claravanstaden
commented
May 6, 2024
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| viper.SetConfigFile("/tmp/snowbridge/beacon-relay.json") |
There was a problem hiding this comment.
Just some cleanup to remove these hardcoded config file paths.
vgeddes
approved these changes
May 7, 2024
claravanstaden
added a commit
that referenced
this pull request
May 9, 2024
* separate endpoint for beacon state * fix interface * default values for config path
claravanstaden
added a commit
that referenced
this pull request
May 30, 2024
* separate endpoint for beacon state * fix interface * default values for config path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure a separate endpoint for the beacon state download, because Lodestar does not backfill ssz states if the node goes offline for a period longer than the weak subjectivity period. This is problematic because we should be able to get historic states. This enables us to switch to a different consensus node for ssz states, if necessary. If all is well, both the
endpointandstateEndpointconfig values can point to Lodestar.