Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Solidity 0.8.22 #992

Merged
merged 6 commits into from
Nov 5, 2023
Merged

Upgrade to Solidity 0.8.22 #992

merged 6 commits into from
Nov 5, 2023

Conversation

vgeddes
Copy link
Collaborator

@vgeddes vgeddes commented Nov 5, 2023

The main improvement this brings is to allow contracts to emit events defined in other files/contracts. This simplifies some of our event emission.

Changes:

  • Contracts now require solidity 0.8.22
  • Updated Foundry version
  • Updates ABI bindings in relayer
  • Smoketest ABI bindings now require serde

Fixes: SNO-730

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab6d7a0) 82.51% compared to head (caccc0f) 83.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
+ Coverage   82.51%   83.29%   +0.77%     
==========================================
  Files          51       51              
  Lines        2065     2065              
  Branches       71       71              
==========================================
+ Hits         1704     1720      +16     
+ Misses        345      330      -15     
+ Partials       16       15       -1     
Flag Coverage Δ
solidity 81.16% <100.00%> (+4.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
contracts/src/Agent.sol 100.00% <ø> (ø)
contracts/src/AgentExecutor.sol 100.00% <ø> (ø)
contracts/src/Assets.sol 78.57% <100.00%> (+10.71%) ⬆️
contracts/src/BeefyClient.sol 87.70% <ø> (ø)
contracts/src/FundAgent.sol 0.00% <ø> (ø)
contracts/src/Gateway.sol 87.16% <ø> (+8.78%) ⬆️
contracts/src/GatewayProxy.sol 100.00% <ø> (ø)
contracts/src/Verification.sol 52.94% <ø> (ø)
contracts/src/storage/AssetsStorage.sol 100.00% <ø> (ø)
contracts/src/storage/CoreStorage.sol 100.00% <ø> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgeddes vgeddes merged commit ef5c74a into main Nov 5, 2023
@vgeddes vgeddes deleted the solidity-0.8.22 branch November 5, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant