Track registered native tokens #994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #994 +/- ##
==========================================
- Coverage 83.25% 83.01% -0.24%
==========================================
Files 51 51
Lines 2060 2067 +7
Branches 71 74 +3
==========================================
+ Hits 1715 1716 +1
- Misses 330 333 +3
- Partials 15 18 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
claravanstaden
approved these changes
Nov 7, 2023
alistair-singh
approved these changes
Nov 7, 2023
yrong
approved these changes
Nov 7, 2023
| @@ -96,6 +104,11 @@ library Assets { | |||
| revert InvalidToken(); | |||
| } | |||
|
|
|||
| if ($.registeredNativeTokens[token]) { | |||
There was a problem hiding this comment.
Just a note here, if token creation fails on the substrate side mapping will be populated and stop a retry by re-submitting the registerToken. Someone would need to fix it manually on the substrate end.
There was a problem hiding this comment.
good point! will remove this check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for implementing the "Polkadot-native assets on Ethereum" story post-launch. It allows the gateway to know whether a particular ERC20 token has been registered or not.