Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Update wrong file path #99

Merged
merged 2 commits into from
Jan 22, 2024
Merged

[Fix] Update wrong file path #99

merged 2 commits into from
Jan 22, 2024

Conversation

charliegerard
Copy link
Contributor

No description provided.

@charliegerard charliegerard changed the title [Fix] [Fix] Update wrong file Jan 19, 2024
@charliegerard charliegerard changed the title [Fix] Update wrong file [Fix] Update wrong file path Jan 19, 2024
@charliegerard charliegerard marked this pull request as ready for review January 19, 2024 21:06
@charliegerard charliegerard requested a review from bmeck January 19, 2024 21:07
Planeshifter
Planeshifter approved these changes Jan 20, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good.

Maybe the variable names with ZSH_BASH_FILE being similar to BASH_FILE, when Zsh and Bash are distinct shells, were to blame for introducing that bug...

@charliegerard charliegerard merged commit 68321b4 into master Jan 22, 2024
14 checks passed
@charliegerard charliegerard deleted the cg/fixPostinstallScript branch January 22, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@bmeck bmeck bmeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charliegerard @bmeck @Planeshifter