Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EBP-482: test to validate only flow thru is not rejected while there is outstanding flow thru #100

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

TrentDaniel
Copy link

Added test to verify that cache requests subsequent to outstanding flow thru request are rejected, except for other flow thru requests.

…anding flow thru request are rejected, except for other flow thru requests.
Copy link

gitstream-cm bot commented Feb 14, 2025

Please mark whether you used Copilot to assist coding in this PR

  • Copilot Assisted

@TrentDaniel TrentDaniel requested a review from sdewilde February 20, 2025 15:20
Copy link

@sdewilde sdewilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making the change!

@TrentDaniel
Copy link
Author

@sdewilde , the merge commit compilation problem that we saw in the PR 102 showed up here as well. PR 103 was opened after both this one (100) and 102, but did not have the compilation problems that 102 and 103 had. So, I'm guessing that there is somehow a git history problem for select branches. I'm going to merge this before waiting for tests to run since they're all going to fail to compile, and I'll have to resolve any issues directly on the feature branch or on a new bugfix branch. Hopefully the git history issue will not occur again in future branches since PR 103 seemed to run smoothly. If it does, then we'll need to investigate it in more detail at that point.

@TrentDaniel TrentDaniel merged commit e9a3cab into SOL-62456 Feb 20, 2025
4 of 5 checks passed
@TrentDaniel TrentDaniel deleted the EBP-482 branch February 20, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants