-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the possibility of to save the data with hostpath. #605
base: master
Are you sure you want to change the base?
Conversation
Hi @jbazp. Thank you for your contribution. It looks like a cool improvement. Could you please rebase your branch against the current master and provide a testing EDIT: when adding your testing Can you also replicate this to the |
Hi @davividal! I made the changes you requested me, Can you check again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you generate both tests/unit-compatibility-test/fixtures/sonarqube-dce/host-path-values.yaml
and tests/unit-compatibility-test/fixtures/sonarqube/host-path-values.yaml
?
They look like a copy of tests/dynamic-compatibility-test/sonarqube-dce/all-values.yaml
and tests/dynamic-compatibility-test/sonarqube/all-values.yaml
.
Did you run the .cirrus/generate_helm_fixtures.sh
script?
Yes! First, I created the values.yaml files:
And finally, I ran .cirrus/generate_helm_fixtures.sh locally and it genereted me the following files:
|
Hi @davividal! Do you need anything else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last fix before I can merge this. :)
@jbazp can you rebase from master, please? |
# Conflicts: # charts/sonarqube-dce/CHANGELOG.md # charts/sonarqube/CHANGELOG.md
@davividal I did the rebase. |
# Conflicts: # charts/sonarqube-dce/CHANGELOG.md
Hi @davividal ! Can you merge the PR? Otherwise I have to do rebase constantly. |
Hi @davividal! The PR is ready for to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @davividal! If there's anything I can help you with, just let me know. |
Sonarqube will not have more than one instance at a time, I want it to always run on a node and within that node save the information with hostpath, I do not want PVC or PV, I want to directly access the host disk to save it and it will go very quickly , easy and without intermediaries (Storage Provider).
Please ensure your pull request adheres to the following guidelines:
CHANGELOG.md
file of the respected chart as well as theChart.yaml