Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONAR-24220 Set a new GCP-Service-name annotation #629

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

carminevassallo
Copy link
Collaborator

@carminevassallo carminevassallo commented Jan 27, 2025

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Fix GCP Service name SONAR-24221 Fix GCP Service name Jan 27, 2025
@carminevassallo carminevassallo changed the title SONAR-24221 Fix GCP Service name [DO NOT MERGE] SONAR-24221 Fix GCP Service name Jan 27, 2025
@carminevassallo carminevassallo force-pushed the task/cv/fix-gcp-service-name branch 8 times, most recently from 515a417 to eb1dd6c Compare January 31, 2025 16:36
@carminevassallo carminevassallo force-pushed the task/cv/fix-gcp-service-name branch from eb1dd6c to fdb92b9 Compare February 3, 2025 17:40
@carminevassallo carminevassallo changed the title [DO NOT MERGE] SONAR-24221 Fix GCP Service name SONAR-24220 Set a new GCP-Service-name annotation Feb 3, 2025
@carminevassallo
Copy link
Collaborator Author

The last commit is only to trigger the job for review. It will get removed after the acceptance.

Copy link
Collaborator

@jCOTINEAU jCOTINEAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor comments but conceptually lgtm !

.cirrus/tasks_gcp_marketplace.yml Outdated Show resolved Hide resolved
.cirrus/tasks_gcp_marketplace.yml Show resolved Hide resolved
@carminevassallo carminevassallo force-pushed the task/cv/fix-gcp-service-name branch from 306bd63 to fdb92b9 Compare February 6, 2025 09:44
Copy link

sonarqube-next bot commented Feb 6, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@carminevassallo carminevassallo merged commit 9e843f4 into master Feb 6, 2025
15 of 16 checks passed
@carminevassallo carminevassallo deleted the task/cv/fix-gcp-service-name branch February 6, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants