Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-JIRA] Point coverage script to the enterprise sonar-go repository #4635

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

petertrr
Copy link
Contributor

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@GabinL21 GabinL21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@petertrr petertrr merged commit 14c80b8 into master Jan 30, 2025
11 of 13 checks passed
@petertrr petertrr deleted the petertrr-patch-1 branch January 30, 2025 09:19
@necto necto added the rspec system Related to handling of rspecs (scripts, doc...) label Feb 3, 2025
@necto
Copy link
Contributor

necto commented Feb 3, 2025

FYI, here is the fix for the missing permission: https://github.com/SonarSource/re-terraform-aws-vault/pull/3791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go rspec system Related to handling of rspecs (scripts, doc...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants