Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD-5219 use Hashicorp Vault to retrieve secrets #583

Merged
merged 3 commits into from
Jun 5, 2024
Merged

BUILD-5219 use Hashicorp Vault to retrieve secrets #583

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a79b4b3
BUILD-5219 Use Hashicorp Vault to retrieve VSCE_TOKEN
sebastienvermeille Jun 4, 2024
a0de38a
BUILD-5219 Use Hashicorp Vault to retrieve OPENVSX_TOKEN
sebastienvermeille Jun 4, 2024
bdeb830
BUILD-5219 Update credcheck.yml workflow accordingly
sebastienvermeille Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ jobs:
with:
secrets: |
development/artifactory/token/{REPO_OWNER_NAME_DASH}-private-reader access_token | ARTIFACTORY_ACCESS_TOKEN;
development/kv/data/visualstudio VSCE_TOKEN | VISUALSTUDIO_PAT;
- name: Install dependencies for vsce-publish
run: |
cp ${GITHUB_WORKSPACE}/.cirrus/.npmrc ./.npmrc
Expand Down Expand Up @@ -91,7 +92,7 @@ jobs:
env:
ARTIFACT_FILE: ${{ steps.download_artifact.outputs.artifactFile }}
TARGET_PLATFORM: ${{ matrix.platform }}
VSCE_TOKEN: ${{ secrets.VISUALSTUDIO_PAT }}
VSCE_TOKEN: ${{ fromJSON(steps.secrets.outputs.vault).VISUALSTUDIO_PAT }}
uses: ./.github/actions/vsce-publish

deploy_to_openvsx:
Expand All @@ -116,6 +117,7 @@ jobs:
with:
secrets: |
development/artifactory/token/{REPO_OWNER_NAME_DASH}-private-reader access_token | ARTIFACTORY_ACCESS_TOKEN;
development/team/sonarlint/kv/data/openvsx token | OPENVSX_TOKEN;
- name: Install dependencies for ovsx-publish
run: |
cp ${GITHUB_WORKSPACE}/.cirrus/.npmrc ./.npmrc
Expand Down Expand Up @@ -154,5 +156,5 @@ jobs:
id: ovsx_publish
env:
ARTIFACT_FILE: ${{ steps.download_artifact.outputs.artifactFile }}
OPENVSX_TOKEN: ${{ secrets.OPENVSX_TOKEN }}
OPENVSX_TOKEN: ${{ fromJSON(steps.secrets.outputs.vault).OPENVSX_TOKEN }}
uses: ./.github/actions/ovsx-publish