Replace VSCode.Uri.path with fsPath when reading SVG files #680
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation,
fsPath
should be used instead ofpath
when reading files on disk. An issue has been reported by users of a fork of SonarLint for VSCode for a custom language, where it was impossible to open the rules description view. Developer console showed this message:Note the double
c:\
at the beginning of the path. The problem doesn't happen in all VS Code environments, but switching to the recommended attributefsPath
solves the problem. I assume the problem can also happen in the standard SonarLint plugin, hence the PR.