[#34] Footer 작업 #37
Merged
[#34] Footer 작업 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intersoom
reviewed
Aug 14, 2023
components/reusable/Footer.tsx
Outdated
| gap: 30px; | ||
| `; | ||
|
|
||
| const WHiteText = styled.div<TextProps>` |
There was a problem hiding this comment.
H까지 대문자로 한 이유가 있나요? 정말 궁금해서 ㅋㅋㅋㅋ
| const WHiteText = styled.div<TextProps>` | ||
| color: ${theme.colors.white}; | ||
| font-size: ${(props) => | ||
| props.size === 'M' ? theme.fontStyles.Text_M.fontSize : theme.fontStyles.Text_L.fontSize}px; |
There was a problem hiding this comment.
이거 true일 경우, px이 안 들어가있어서 그런거 아닐까용?
There was a problem hiding this comment.
{}px 한꺼번에 묶어서 한건데.. 후우움
intersoom
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
Details
To Reviewer
After Work
Reference