Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DIDs to config file #89

Merged
merged 36 commits into from
Jun 10, 2024

Conversation

anjastrunk
Copy link
Contributor

@anjastrunk anjastrunk commented Apr 22, 2024

related to #70

Signed-off-by: Anja Strunk <[email protected]>
@anjastrunk anjastrunk added the SCS-VP10 Related to tender lot SCS-VP10 label Apr 22, 2024
@anjastrunk anjastrunk self-assigned this Apr 22, 2024
anjastrunk and others added 26 commits April 23, 2024 13:18
…f github.com:SovereignCloudStack/gx-self-description-generator into 70-support-did-in-generated-gaia-x-credentials_task2
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
…f github.com:SovereignCloudStack/gx-credential-generator into 70-support-did-in-generated-gaia-x-credentials_task2
Signed-off-by: Anja Strunk <[email protected]>
Copy link
Member

@martinmo martinmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found typos, apart from that looks good.

Out of curiosity: how is the gx_schema.py file generated? Does it make sense to add instructions/tooling for that to this repository? For example, which tools and inputs are needed and where to get them from?

generator/discovery/openstack/openstack_discovery.py Outdated Show resolved Hide resolved
generator/discovery/openstack/openstack_discovery.py Outdated Show resolved Hide resolved
generator/discovery/openstack/openstack_discovery.py Outdated Show resolved Hide resolved
generator/discovery/openstack/openstack_discovery.py Outdated Show resolved Hide resolved
tests/test_cli.py Outdated Show resolved Hide resolved
anjastrunk and others added 4 commits June 10, 2024 07:33
Co-authored-by: Martin Morgenstern <[email protected]>
Signed-off-by: anjastrunk <[email protected]>
Co-authored-by: Martin Morgenstern <[email protected]>
Signed-off-by: anjastrunk <[email protected]>
Co-authored-by: Martin Morgenstern <[email protected]>
Signed-off-by: anjastrunk <[email protected]>
Co-authored-by: Martin Morgenstern <[email protected]>
Signed-off-by: anjastrunk <[email protected]>
@anjastrunk
Copy link
Contributor Author

Just found typos, apart from that looks good.

Out of curiosity: how is the gx_schema.py file generated? Does it make sense to add instructions/tooling for that to this repository? For example, which tools and inputs are needed and where to get them from?

This file is auto-generated bx linkml. I will extend doc to point this out.

Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
Copy link

Code Coverage

Package Line Rate Health
. 82%
common 100%
discovery.openstack 99%
Summary 98% (583 / 594)

Minimum allowed line rate is 90%

@anjastrunk anjastrunk merged commit ffc8bc6 into main Jun 10, 2024
6 checks passed
@anjastrunk anjastrunk deleted the 70-support-did-in-generated-gaia-x-credentials_task2 branch June 10, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SCS-VP10 Related to tender lot SCS-VP10
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants