Skip to content

Commit

Permalink
Fixup: remove version parameter form delete
Browse files Browse the repository at this point in the history
Signed-off-by: Toni Finger <[email protected]>
  • Loading branch information
tonifinger committed Nov 11, 2024
1 parent 932ed7a commit a96047d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
5 changes: 2 additions & 3 deletions Tests/kaas/plugin/interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def create_cluster(self, cluster_name, version, kubeconfig_filepath):
self.cluster = ClusterAPI(name=cluster_name, image=cluster_image, kubeconfig_filepath)
self.cluster.create(self.config)
def delete_cluster(self, cluster_name, version):
def delete_cluster(self, cluster_name):
self.cluster = ClusterAPI(cluster_name)
self.cluster.delete()
..
Expand All @@ -46,10 +46,9 @@ def create_cluster(self, cluster_name, version, kubeconfig_filepath):
"""
raise NotImplementedError

def delete_cluster(self, cluster_name, version):
def delete_cluster(self, cluster_name):
"""
This method is to be called in order to unprovision a cluster
:param: cluster_name:
:param: version:
"""
raise NotImplementedError
2 changes: 1 addition & 1 deletion Tests/kaas/plugin/plugin_kind.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@ def create_cluster(self, cluster_name, version, kubeconfig):
else:
self.cluster.create(self.config)

def delete_cluster(self, cluster_name, version):
def delete_cluster(self, cluster_name):
self.cluster = KindCluster(cluster_name)
self.cluster.delete()
2 changes: 1 addition & 1 deletion Tests/kaas/plugin/run_plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def delete(plugin_kind, plugin_config, clusterspec_path, clusterspec_cluster):
clusterinfo = clusterspec[clusterspec_cluster]
cluster_id = clusterspec_cluster
plugin = init_plugin(plugin_kind, plugin_config)
plugin.delete_cluster(cluster_id, clusterinfo['branch'])
plugin.delete_cluster(cluster_id)


if __name__ == '__main__':
Expand Down

0 comments on commit a96047d

Please sign in to comment.