Refactor to reduce degree of nesting (#431)

* Refactor to reduce degree of nesting * Improve comment (which would otherwise be misleading) Signed-off-by: Matthias Büchse <[email protected]> Signed-off-by: Kurt Garloff <[email protected]> Co-authored-by: Kurt Garloff <[email protected]>
SovereignCloudStack · Dec 22, 2023 · e56929a · e56929a
1 parent b97f9d4
commit e56929a
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/Tests/iaas/image-metadata/image-md-check.py b/Tests/iaas/image-metadata/image-md-check.py
@@ -173,14 +173,14 @@ def validate_imageMD(imgnm):
                   f'{img.properties["image_build_date"]}', file=sys.stderr)
             errors += 1
     # - image_source should be a URL
-    if "image_source" in img.properties:
-        if not is_url(img.properties["image_source"]):
-            if img.properties["image_source"] == "private":
-                if verbose:
-                    print(f'Info: Image {imgnm} has image_source set to private', file=sys.stderr)
-            else:
-                print(f'Error: Image "{imgnm}": image_source should be a URL or "private"', file=sys.stderr)
-                errors += 1
+    if "image_source" not in img.properties:
+        pass  # we have already noted this as error, no need to do it again
+    elif img.properties["image_source"] == "private":
+        if verbose:
+            print(f'Info: Image {imgnm} has image_source set to private', file=sys.stderr)
+    elif not is_url(img.properties["image_source"]):
+        print(f'Error: Image "{imgnm}": image_source should be a URL or "private"', file=sys.stderr)
+        errors += 1
     #  - uuid_validity has a distinct set of options (none, last-X, DATE, notice, forever)
     #  - hotfix hours (if set!) should be numeric
     # (5a) Sanity: Are we actually in violation of update_frequency?